[Home] [Downloads] [Search] [Help/forum]

Gammon Software Solutions forum

See www.mushclient.com/spam for dealing with forum spam. Please read the MUSHclient FAQ!

[Folder]  Entire forum
-> [Folder]  MUSHclient
. -> [Folder]  Bug reports
. . -> [Subject]  OpenBrowser length limit

Home  |  Users  |  Search  |  FAQ
Username:
Register forum user name
Password:
Forgotten password?

OpenBrowser length limit

[Reply to this subject]  Reply to this subject   [New subject]  Start a new subject   [Refresh] Refresh page


Posted by Fiendish   USA  (848 posts)  [Biography] bio   Global Moderator
Date Tue 26 Jul 2011 09:23 PM (UTC)  quote  ]

Amended on Tue 26 Jul 2011 09:28 PM (UTC) by Fiendish

Message
OpenBrowser appears to have a length limit of 259 characters, which is not a reasonable limitation. The maximum size allowed (if any) should be much higher than that.

http://aardwolfclientpackage.googlecode.com/
[Go to top] top

Posted by Nick Gammon   Australia  (18,770 posts)  [Biography] bio   Forum Administrator
Date Reply #1 on Tue 26 Jul 2011 10:53 PM (UTC)  quote  ]
Message
Where do you see that limitation in the source?


long CMUSHclientDoc::OpenBrowser(LPCTSTR URL) 
{
CString strAction = URL;

    if (strAction.IsEmpty ())
      return eBadParameter;

    // don't let them slip in arbitrary OS commands
    if (strAction.Left (7).CompareNoCase ("http://") != 0 &&
        strAction.Left (8).CompareNoCase ("https://") != 0 &&
        strAction.Left (7).CompareNoCase ("mailto:") != 0)
      return eBadParameter;

    if ((long) ShellExecute (Frame, _T("open"), strAction, NULL, NULL, SW_SHOWNORMAL) <= 32)
      return eCouldNotOpenFile;

	return eOK;
}   // end of CMUSHclientDoc::OpenBrowser


- Nick Gammon

www.gammon.com.au, www.mushclient.com
[Go to top] top

Posted by Fiendish   USA  (848 posts)  [Biography] bio   Global Moderator
Date Reply #2 on Wed 27 Jul 2011 03:35 AM (UTC)  quote  ]

Amended on Wed 27 Jul 2011 03:36 AM (UTC) by Fiendish

Message
I didn't look at the source, I found the problem in practice. Never mind. It looks like it's yet another wine bug. *sigh*

http://aardwolfclientpackage.googlecode.com/
[Go to top] top

The dates and times for posts above are shown in Universal Co-ordinated Time (UTC).

To show them in your local time you can join the forum, and then set the 'time correction' field in your profile to the number of hours difference between your location and UTC time.


1,125 views.

[Reply to this subject]  Reply to this subject   [New subject]  Start a new subject   [Refresh] Refresh page

Go to topic:           Search the forum


[Go to top] top

[Home]

Written by Nick Gammon - 5K

Comments to: Gammon Software support
[RH click to get RSS URL] Forum RSS feed ( http://www.gammon.com.au/rss/forum.xml )

[Best viewed with any browser - 2K]    [Internet Contents Rating Association (ICRA) - 2K]    [Web site powered by FutureQuest.Net]