Notice: Any messages purporting to come from this site telling you that your password has expired, or that you need to verify your details, confirm your email, resolve issues, making threats, or asking for money, are
spam. We do not email users with any such messages. If you have lost your password you can obtain a new one by using the
password reset link.
Due to spam on this forum, all posts now need moderator approval.
Entire forum
➜ MUSHclient
➜ Bug reports
➜ SetScroll(x, false) hammers OnPluginWorldOutputResized
|
SetScroll(x, false) hammers OnPluginWorldOutputResized
|
It is now over 60 days since the last post. This thread is closed.
Refresh page
| Posted by
| Fiendish
USA (2,551 posts) Bio
Global Moderator |
| Date
| Fri 03 Jan 2020 09:22 PM (UTC) Amended on Tue 07 Jan 2020 05:30 AM (UTC) by Fiendish
|
| Message
| Load this plugin into a blank world and scroll up/down and watch the status bar. [EDIT] On affected systems it counts up very rapidly and shows the window width bouncing back and forth.
<?xml version="1.0" encoding="iso-8859-1"?>
<!DOCTYPE muclient>
<muclient>
<plugin
name="Resize_Test"
author="Fiendish"
id="aaaaaaaaaaaaaaaaaaaaaaaa"
language="Lua"
requires="4.00"
version="1.0"
>
</plugin>
<script>
<![CDATA[
for i=1,1000 do
Note('foo', i)
end
SetScroll(-2, false)
i = 0
function OnPluginWorldOutputResized()
i = i + 1
SetStatus(i, " ", GetInfo(281))
end
]]>
</script>
</muclient>
|
https://github.com/fiendish/aardwolfclientpackage | | Top |
|
| Posted by
| Fiendish
USA (2,551 posts) Bio
Global Moderator |
| Date
| Reply #1 on Sat 04 Jan 2020 09:36 AM (UTC) Amended on Sat 04 Jan 2020 09:38 AM (UTC) by Fiendish
|
| Message
| Replacing SetScrollInfo with SetScrollInfo in this one spot appears to fix it (no more transient scrollbar pop-in), though I don't really understand why SetScrollInfo doesn't work right there.
https://github.com/fiendish/mushclient/commit/ef5b905e17a8be598981cbd3e34634e119266d80 |
https://github.com/fiendish/aardwolfclientpackage | | Top |
|
| Posted by
| Fiendish
USA (2,551 posts) Bio
Global Moderator |
| Date
| Reply #2 on Sun 05 Jan 2020 03:20 AM (UTC) Amended on Sun 05 Jan 2020 03:21 AM (UTC) by Fiendish
|
| Message
|
Quote:
Replacing SetScrollInfo with SetScrollInfo
I mean replacing SetScrollInfo with SetScrollPos, of course |
https://github.com/fiendish/aardwolfclientpackage | | Top |
|
| Posted by
| Nick Gammon
Australia (23,169 posts) Bio
Forum Administrator |
| Date
| Reply #3 on Sun 05 Jan 2020 04:16 AM (UTC) |
| Message
| | I wondered about that. |
- Nick Gammon
www.gammon.com.au, www.mushclient.com | | Top |
|
| Posted by
| Fiendish
USA (2,551 posts) Bio
Global Moderator |
| Date
| Reply #4 on Tue 07 Jan 2020 05:23 AM (UTC) Amended on Tue 07 Jan 2020 06:22 AM (UTC) by Fiendish
|
| Message
| After some testing on real Windows, I think it's possible that this only affects Wine, or at least that it doesn't affect the latest version of Windows 10, or at least it definitely affects the latest version of Wine on a macbook running macOS Mojave. But I think it should be patched in MUSHclient anyway to protect Wine users and possibly others. The unpatched behavior makes it functionally impossible to play with a hidden scrollbar on affected systems, because scrolling at all hits the system so hard because the scrollbar appears and disappears hundreds of times per second.
My reason for looking into this is that I implemented the idea in https://www.gammon.com.au/forum/?id=10550&reply=3 with my miniwindow scrollbar module, and it's really nice when it works, but it requires this patch to work with the original bar hidden. |
https://github.com/fiendish/aardwolfclientpackage | | Top |
|
| Posted by
| Nick Gammon
Australia (23,169 posts) Bio
Forum Administrator |
| Date
| Reply #5 on Tue 07 Jan 2020 06:40 AM (UTC) |
| Message
| | Didn't I implement your last Git push? Or is this a separate one? |
- Nick Gammon
www.gammon.com.au, www.mushclient.com | | Top |
|
| Posted by
| Fiendish
USA (2,551 posts) Bio
Global Moderator |
| Date
| Reply #6 on Tue 07 Jan 2020 02:05 PM (UTC) |
| Message
| |
| Posted by
| Nick Gammon
Australia (23,169 posts) Bio
Forum Administrator |
| Date
| Reply #7 on Thu 09 Jan 2020 11:06 PM (UTC) |
| Message
| | Merged now. |
- Nick Gammon
www.gammon.com.au, www.mushclient.com | | Top |
|
The dates and times for posts above are shown in Universal Co-ordinated Time (UTC).
To show them in your local time you can join the forum, and then set the 'time correction' field in your profile to the number of hours difference between your location and UTC time.
25,565 views.
It is now over 60 days since the last post. This thread is closed.
Refresh page
![[Go to top]](/images/gototop.gif)
top