[Home] [Downloads] [Search] [Help/forum]

Register forum user name Search FAQ

Gammon Forum

Notice: Any messages purporting to come from this site telling you that your password has expired, or that you need to "verify" your details, making threats, or asking for money, are spam. We do not email users with any such messages. If you have lost your password you can obtain a new one by using the password reset link.
 Entire forum ➜ MUDs ➜ General ➜ Is GMCP still a thing?
Is GMCP still a thing?

It is now over 60 days since the last post. This thread is closed.     Refresh page

Pages: 1  2  3  4  5 6  7  

Posted by Xinefus   (106 posts)  Bio
Date Reply #60 on Mon 11 May 2020 01:40 PM (UTC)
Message
I thought of using Nick's version, however there are a lot of changes involved in that one. I wasn't going to jump into that unless I had to. First off is the codebase i'm using doesn't have the std::string defined. So that would be a start I suppose.

I hadn't wanted to do a whole rewrite to a mud if I could help it.

Maybe it is something I should do however, but this is all just to help me get this working on a more heavily modified codebase that is 'like' SMAUGFUSS1.9. I don't want to change too much in a vanilla type just to see that it will be even more work on this more modified version. But maybe updating read from buffer won't change too much...
Top
Posted by Fiendish   USA  (2,533 posts)  Bio   Global Moderator
Date Reply #61 on Mon 11 May 2020 04:40 PM (UTC)

Amended on Mon 11 May 2020 05:02 PM (UTC) by Fiendish

Message
Quote:
I thought of using Nick's version, however there are a lot of changes involved in that one.
You're right. But I guess I don't know if Nick's original commit actually worked before his refactor.

Nick, do you remember the context for https://github.com/nickgammon/smaugfuss/commit/45b5f0491f9197aa6c413cb8483e8983c4483ba2 and whether the comm.c in that commit worked as is?


Xinefus,
Why does https://github.com/DBNU-Braska/SMAUG_GMCP/blob/master/comm.c#L1412 remove the else vs https://github.com/nickgammon/smaugfuss/blob/45b5f0491f9197aa6c413cb8483e8983c4483ba2/src/comm.c#L1414 ?

I still would like to see what the server is actually receiving that it doesn't like.
https://github.com/fiendish/aardwolfclientpackage
Top
Posted by Nick Gammon   Australia  (23,046 posts)  Bio   Forum Administrator
Date Reply #62 on Mon 11 May 2020 08:50 PM (UTC)
Message
Fiendish said:

Nick, do you remember the context for https://github.com/nickgammon/smaugfuss/commit/45b5f0491f9197aa6c413cb8483e8983c4483ba2 and whether the comm.c in that commit worked as is?


I think so, I normally test stuff before committing it. What part looks doubtful?
- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top
Posted by Fiendish   USA  (2,533 posts)  Bio   Global Moderator
Date Reply #63 on Mon 11 May 2020 10:07 PM (UTC)
Message
Quote:
What part looks doubtful?

No part. Just checking for possible reasons for the noted error in the absence of concrete information about why the server is complaining.
https://github.com/fiendish/aardwolfclientpackage
Top
Posted by Xinefus   (106 posts)  Bio
Date Reply #64 on Tue 12 May 2020 12:30 AM (UTC)
Message
Thanks for sharing that commit, I hadn't found that one and it is effectively what I did to my version.

Just to go over the changes that I have done, I have changed the read_from_buffer to enable negotiation for the MUD_SPECIFIC items, and I have put in the fixup_lua_strings so that I can get name/victim names to work in MUSHclient.

What exactly do you want me to do to help debug. I'm not very good at knowing where/what to slip in there to enable the server to spit out the errors it is getting. I've never used gdb before so I'm trying to read some tutorials on this but would like some assistance if possible.

note, you can see my complete source on my git. Perhaps you can replicate the problem I am having.
Top
Posted by Xinefus   (106 posts)  Bio
Date Reply #65 on Tue 12 May 2020 12:41 AM (UTC)

Amended on Tue 12 May 2020 12:47 AM (UTC) by Xinefus

Message
I'm really going down a rabbit hole here...

Where should I be setting a break for gdb to catch this?



Thanks.
Top
Posted by Fiendish   USA  (2,533 posts)  Bio   Global Moderator
Date Reply #66 on Tue 12 May 2020 05:54 AM (UTC)

Amended on Tue 12 May 2020 05:55 AM (UTC) by Fiendish

Message
You said you're getting "Illegal name, try another."
When the server sends that, what exactly was the name that it thinks it got? Ideally I would like to see a printout of every single message coming into the server from the client at the time that occurs.
https://github.com/fiendish/aardwolfclientpackage
Top
Posted by Nick Gammon   Australia  (23,046 posts)  Bio   Forum Administrator
Date Reply #67 on Tue 12 May 2020 06:18 AM (UTC)
Message
You haven't made the changes I suggested in reply #57.

The "illegal name" thing sounds like you have put into the input buffer some of the IAC stuff, which suggests that the telnet negotiation stuff isn't working, which you already know anyway.
- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top
Posted by Fiendish   USA  (2,533 posts)  Bio   Global Moderator
Date Reply #68 on Tue 12 May 2020 04:37 PM (UTC)
Message
Xinefus said:
it is effectively what I did to my version


Except that you're missing an else.
https://github.com/fiendish/aardwolfclientpackage
Top
Posted by Xinefus   (106 posts)  Bio
Date Reply #69 on Tue 12 May 2020 07:05 PM (UTC)
Message
I have (maybe it wasn't completely up to date on Git) c/p the read_from_buffer from https://github.com/nickgammon/smaugfuss/blob/master/src/comm.c to mine. I do still get the error.

I'm looking at trying to do what is done in the 'status messages' commit.

As I've been doing these changes, I am getting a bit more comfortable in how navigate the mud. I do like the case format a lot better, it just looks really nice and it probably runs a heck of a lot smoother.

If I am trying to implement this in to a modified MUD based off SMAUGFUSS1.9 and I wanted to begin the process of updating parts to the 'status_messages' (https://github.com/nickgammon/smaugfuss/tree/status_messages), where would you suggest I actually start? Looking at the commits from Git, it doesn't 'look' like all files have been modified within /src but is there a way to be able to iteratively get this started?
Top
Posted by Nick Gammon   Australia  (23,046 posts)  Bio   Forum Administrator
Date Reply #70 on Wed 13 May 2020 06:24 AM (UTC)
Message
Your code looks completely different to my code at:


https://github.com/nickgammon/smaugfuss/blob/status_messages/src/comm.c#L1300

Notice the extensive use of switch statements, rather than a lot of nested "if"s.
- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top
Posted by Nick Gammon   Australia  (23,046 posts)  Bio   Forum Administrator
Date Reply #71 on Wed 13 May 2020 06:25 AM (UTC)
Message
Xinefus said:

I thought of using Nick's version, however there are a lot of changes involved in that one. I wasn't going to jump into that unless I had to. First off is the codebase i'm using doesn't have the std::string defined. So that would be a start I suppose.


I think you compile with g++ rather than gcc to fix that.
- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top
Posted by Fiendish   USA  (2,533 posts)  Bio   Global Moderator
Date Reply #72 on Wed 13 May 2020 12:52 PM (UTC)

Amended on Wed 13 May 2020 12:54 PM (UTC) by Fiendish

Message
Quote:
I have (maybe it wasn't completely up to date on Git) c/p the read_from_buffer from https://github.com/nickgammon/smaugfuss/blob/master/src/comm.c to mine.

The master branch in that repository does not include the necessary updates. You want the status_messages branch.


https://github.com/nickgammon/smaugfuss/blob/master/src/comm.c
and
https://github.com/nickgammon/smaugfuss/blob/status_messages/src/comm.c
are not the same
https://github.com/fiendish/aardwolfclientpackage
Top
Posted by Fiendish   USA  (2,533 posts)  Bio   Global Moderator
Date Reply #73 on Wed 13 May 2020 12:57 PM (UTC)

Amended on Wed 13 May 2020 12:58 PM (UTC) by Fiendish

Message
Nick Gammon said:
I think you compile with g++ rather than gcc to fix that.

It's a little weird to switch a C project to C++ to bring in string.h, lol.
https://github.com/fiendish/aardwolfclientpackage
Top
Posted by Xinefus   (106 posts)  Bio
Date Reply #74 on Wed 13 May 2020 02:56 PM (UTC)
Message
Thanks for the support guys.

I'm working on getting a test-copy of the actual mud I want to be doing this implementation on. I am getting discouraged doing all these changes just on a blank slate and it doesn't mean it will work on the production MUD.


I'm going to take a few days to get setup. I'll be back soon!

Suuupper thank you! I am learning so much. My wife has also pulled out some of her old books and is super interested in this. She doesn't like gaming, but the coding part has sparked her interest.

Cheers!
Top

The dates and times for posts above are shown in Universal Co-ordinated Time (UTC).

To show them in your local time you can join the forum, and then set the 'time correction' field in your profile to the number of hours difference between your location and UTC time.

191,677 views.

This is page 5, subject is 7 pages long:  [Previous page]  1  2  3  4  5 6  7  [Next page]

It is now over 60 days since the last post. This thread is closed.     Refresh page

Go to topic:           Search the forum

[Go to top] top

Quick links: MUSHclient. MUSHclient help. Forum shortcuts. Posting templates. Lua modules. Lua documentation.

Information and images on this site are licensed under the Creative Commons Attribution 3.0 Australia License unless stated otherwise.

[Home]