Notice: Any messages purporting to come from this site telling you that your password has expired, or that you need to verify your details, confirm your email, resolve issues, making threats, or asking for money, are
spam. We do not email users with any such messages. If you have lost your password you can obtain a new one by using the
password reset link.
Entire forum
➜ MUSHclient
➜ Bug reports
➜ Bug Switching to another window when opening any settings dialog
|
Bug Switching to another window when opening any settings dialog
|
It is now over 60 days since the last post. This thread is closed.
Refresh page
| Posted by
| Gore
(207 posts) Bio
|
| Date
| Mon 02 Apr 2007 09:53 AM (UTC) |
| Message
| For some reason mushclient is switching to another program and then switching back whenever I open any of the settings dialogs. Any ideas?
Started with version 4.00/4.01, downgraded to 3.85 and seems to do it on that as well.
| | Top |
|
| Posted by
| Onoitsu2
USA (248 posts) Bio
|
| Date
| Reply #1 on Mon 02 Apr 2007 11:03 AM (UTC) |
| Message
| | might have to do with another open program fighting for active status, or "on-top" status, that happens in the split second before the settings dialog actually is spawned. | | Top |
|
| Posted by
| Gore
(207 posts) Bio
|
| Date
| Reply #2 on Mon 02 Apr 2007 11:10 AM (UTC) |
| Message
| Doesn't matter what program it is, the last active window prior to mushclient becomes active for a moment.
Had it working right for a moment, not sure what I did.. but I closed my world file reopened and the bug came back. | | Top |
|
| Posted by
| Zeno
USA (2,871 posts) Bio
|
| Date
| Reply #3 on Mon 02 Apr 2007 02:07 PM (UTC) |
| Message
| | No problems here. Sounds like it's a bug with Windows. I know that for example the starting MUSHClient graphic has black blotches on it, but that's a bug not of MUHSclient but an issues with the Windows registry. |
Zeno McDohl,
Owner of Bleached InuYasha Galaxy
http://www.biyg.org | | Top |
|
| Posted by
| Nick Gammon
Australia (23,120 posts) Bio
Forum Administrator |
| Date
| Reply #4 on Mon 02 Apr 2007 09:31 PM (UTC) |
| Message
| I had been noticing something along those lines recently, but couldn't put my finger on it. It seemed to flicker slightly when you opened the world configuration.
I think it started in 3.85, when I look at it more closely. There was a new feature there that the memory usage was only calculated on demand (clicking a button), and when you did so a progress dialog appeared.
However due to the way it was coded, if you had less than 1000 lines in the output window, the progress bar still appeared, very briefly. This probably accounts for the flicker. That will be fixed in version 4.02. The patch to the source, in case Zeno wants to try it, is:
$ cvs diff -c prefspropertypages.cpp
Index: prefspropertypages.cpp
===================================================================
RCS file: /cvs/mushclient/prefspropertypages.cpp,v
retrieving revision 1.92
diff -c -r1.92 prefspropertypages.cpp
*** prefspropertypages.cpp 1 Apr 2007 04:44:31 -0000 1.92
--- prefspropertypages.cpp 2 Apr 2007 21:29:01 -0000
***************
*** 8268,8278 ****
void CPrefsP15::CalculateMemoryUsage ()
{
! CProgressDlg ProgressDlg;
! ProgressDlg.Create ();
! ProgressDlg.SetStatus ("Calculating memory usage...");
! ProgressDlg.SetRange (0, m_doc->m_LineList.GetCount ());
! ProgressDlg.SetWindowText ("Memory used by output buffer");
// work out how much memory each line takes
--- 8268,8283 ----
void CPrefsP15::CalculateMemoryUsage ()
{
! CProgressDlg * pProgressDlg = NULL;
!
! if (m_doc->m_LineList.GetCount () > 1000)
! {
! pProgressDlg = new CProgressDlg;
! pProgressDlg->Create ();
! pProgressDlg->SetStatus ("Calculating memory usage...");
! pProgressDlg->SetRange (0, m_doc->m_LineList.GetCount ());
! pProgressDlg->SetWindowText ("Memory used by output buffer");
! }
// work out how much memory each line takes
***************
*** 8286,8296 ****
{
iCount++;
! if ((iCount & 63) == 0)
! ProgressDlg.SetPos (iCount);
! if (ProgressDlg.CheckCancelButton()) // abort if user cancels
! return;
CLine * pLine = m_doc->m_LineList.GetNext (pos);
nMemory += sizeof CLine; // add the class itself
--- 8291,8307 ----
{
iCount++;
! if (pProgressDlg)
! {
! if ((iCount & 63) == 0)
! pProgressDlg->SetPos (iCount);
! if (pProgressDlg->CheckCancelButton()) // abort if user cancels
! {
! delete pProgressDlg;
! return;
! }
! }
CLine * pLine = m_doc->m_LineList.GetNext (pos);
nMemory += sizeof CLine; // add the class itself
***************
*** 8330,8335 ****
--- 8341,8348 ----
GetDlgItem (IDC_CALCULATE_MEMORY)->EnableWindow (FALSE); // only do it once
+
+ delete pProgressDlg;
} // end of CPrefsP15::CalculateMemoryUsage
|
- Nick Gammon
www.gammon.com.au, www.mushclient.com | | Top |
|
| Posted by
| Zeno
USA (2,871 posts) Bio
|
| Date
| Reply #5 on Tue 03 Apr 2007 02:49 AM (UTC) |
| Message
| | I'd patch that in if I could actually get MC to show me what you guys are talking about. :P |
Zeno McDohl,
Owner of Bleached InuYasha Galaxy
http://www.biyg.org | | Top |
|
| Posted by
| Nick Gammon
Australia (23,120 posts) Bio
Forum Administrator |
| Date
| Reply #6 on Tue 03 Apr 2007 03:51 AM (UTC) |
| Message
| | Make a new session with less than 1000 lines in the output window. Then when you open the configuration window if you watch closely you will see the progress bar flicker in, which makes the whole client window flicker into inactivity for a moment. |
- Nick Gammon
www.gammon.com.au, www.mushclient.com | | Top |
|
| Posted by
| Zeno
USA (2,871 posts) Bio
|
| Date
| Reply #7 on Tue 03 Apr 2007 04:05 AM (UTC) |
| Message
| Ah, under 1000 lines. Okay yeah, I see it now.
Patched applied, seems fine now. |
Zeno McDohl,
Owner of Bleached InuYasha Galaxy
http://www.biyg.org | | Top |
|
| Posted by
| Gore
(207 posts) Bio
|
| Date
| Reply #8 on Wed 04 Apr 2007 03:12 AM (UTC) |
| Message
| |
The dates and times for posts above are shown in Universal Co-ordinated Time (UTC).
To show them in your local time you can join the forum, and then set the 'time correction' field in your profile to the number of hours difference between your location and UTC time.
23,786 views.
It is now over 60 days since the last post. This thread is closed.
Refresh page
![[Go to top]](/images/gototop.gif)
top