Register forum user name Search FAQ

Gammon Forum

Notice: Any messages purporting to come from this site telling you that your password has expired, or that you need to verify your details, confirm your email, resolve issues, making threats, or asking for money, are spam. We do not email users with any such messages. If you have lost your password you can obtain a new one by using the password reset link.

Due to spam on this forum, all posts now need moderator approval.

 Entire forum ➜ MUSHclient ➜ Bug reports ➜ TextRectangle, TELOPT_NAWS and window sizes

TextRectangle, TELOPT_NAWS and window sizes

It is now over 60 days since the last post. This thread is closed.     Refresh page


Posted by Astarte   Germany  (8 posts)  Bio
Date Sun 03 Jan 2010 01:43 AM (UTC)

Amended on Sun 03 Jan 2010 01:12 PM (UTC) by Astarte

Message
I've been toying with TextRectangle and found that

  • it might be enhanced by just sending new TELOPT_NAWS for a change in size
  • even if you enforce an update by e. g. computing wrap_column manually and use SetOption("wrap_column", newValue), the height will not be computed according to your rectangle which I think is a bug


To amend the latter, I visited
void CMUSHclientDoc::SendWindowSizes (const int iNewWidth)
and replaced

  • pmyView->GetClientRect (&r);


with

  • pmyView->GetTextRect (&r);


and tried it out. It seems to work quite nicely. Maybe you can use this in a future release.

Top

Posted by Nick Gammon   Australia  (23,173 posts)  Bio   Forum Administrator
Date Reply #1 on Sun 03 Jan 2010 07:22 PM (UTC)
Message
Sounds like a bug, as the NAWS stuff predated the TextRectangle stuff.

I have added the NAWS notification to TextRectangle.

I have amended the size calculation to your suggestion.

Available in version 4.46.

- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top

Posted by Astarte   Germany  (8 posts)  Bio
Date Reply #2 on Sun 03 Jan 2010 07:50 PM (UTC)
Message
Rocks, thank you.
Top

The dates and times for posts above are shown in Universal Co-ordinated Time (UTC).

To show them in your local time you can join the forum, and then set the 'time correction' field in your profile to the number of hours difference between your location and UTC time.


12,358 views.

It is now over 60 days since the last post. This thread is closed.     Refresh page

Go to topic:           Search the forum


[Go to top] top

Information and images on this site are licensed under the Creative Commons Attribution 3.0 Australia License unless stated otherwise.