[Home] [Downloads] [Search] [Help/forum]

Gammon Software Solutions forum

See www.mushclient.com/spam for dealing with forum spam. Please read the MUSHclient FAQ!

[Folder]  Entire forum
-> [Folder]  MUDs
. -> [Folder]  General
. . -> [Subject]  Tiny MUD Server - version 2
Home  |  Users  |  Search  |  FAQ
Username:
Register forum user name
Password:
Forgotten password?
(New message)
Subject: Tiny MUD Server - version 2
Name:
Your forum user name.
Register forum user name
Password:
Your forum password.
Forgotten password?
Message:
Message to be posted (in English, please).
Forum codes:
Check this if your message uses 'forum codes' or templates (auto-detected for new posts).
Forum codes Templates

Save this message ...

Subject review (reverse sequence)

Pages: 1 2  3  4  5  6  7  8  

Posted by Nick Gammon   Australia  (18,770 posts)  [Biography] bio   Forum Administrator
Date Fri 22 Oct 2010 07:56 PM (UTC)  [ quote  ]
Message
Fixed in latest commit:

http://github.com/nickgammon/tinymudserver/commit/03e003403e
- Nick Gammon

www.gammon.com.au, www.mushclient.com
[Go to top] top
Posted by Kyle Chappetta   (3 posts)  [Biography] bio
Date Fri 22 Oct 2010 03:16 PM (UTC)  [ quote  ]

Amended on Fri 22 Oct 2010 03:26 PM (UTC) by Kyle Chappetta

Message
Howdy. I wasn't sure where to post this, so I posted it here. I've downloaded Tiny Mud from GitHub, but I ran into a compile error that I don't know how to correct. Below is the log from my terminal when I typed "make". Can anyone help?

kyle@ubuntu:~/Downloads/tinymudserver$ make
g++ -g3 -Wall -w -pedantic -fmessage-length=0 -c tinymudserver.cpp
g++ -MM tinymudserver.cpp > tinymudserver.d
g++ -g3 -Wall -w -pedantic -fmessage-length=0 -c strings.cpp
g++ -MM strings.cpp > strings.d
g++ -g3 -Wall -w -pedantic -fmessage-length=0 -c player.cpp
g++ -MM player.cpp > player.d
g++ -g3 -Wall -w -pedantic -fmessage-length=0 -c load.cpp
g++ -MM load.cpp > load.d
g++ -g3 -Wall -w -pedantic -fmessage-length=0 -c commands.cpp
g++ -MM commands.cpp > commands.d
g++ -g3 -Wall -w -pedantic -fmessage-length=0 -c states.cpp
g++ -MM states.cpp > states.d
g++ -g3 -Wall -w -pedantic -fmessage-length=0 -c globals.cpp
g++ -MM globals.cpp > globals.d
g++ -g3 -Wall -w -pedantic -fmessage-length=0 -c comms.cpp
comms.cpp: In function 'int InitComms()':
comms.cpp:104: error: 'perror' was not declared in this scope
comms.cpp: In function 'void ProcessNewConnection()':
comms.cpp: 211: error: 'perror' was not declared in this scope
comms.cpp:219: error: 'perror' was not declared in this scope
make: *** [comms.o] Error 1

[Go to top] top
Posted by Nick Gammon   Australia  (18,770 posts)  [Biography] bio   Forum Administrator
Date Mon 04 Oct 2010 05:59 AM (UTC)  [ quote  ]

Amended on Mon 04 Oct 2010 08:43 PM (UTC) by Nick Gammon

Message
The thing that bothers me a bit about the output iterator on the previous page is that it has the tPlayer type hard-coded into it. A bit of juggling and you can make an output iterator for any type:


template <typename CharT>
class generic_output_iterator : public std::iterator <std::output_iterator_tag, CharT, void, void, void>
{
 protected:
   CharT      & item_;     // item we are outputting to
   const char * delim_;    // delimiter between each thing output
   
 public:
  // constructor
  generic_output_iterator (CharT & c, const char* d = "")
    : item_ (c), delim_ (d) { }
  
  // copy constructor
  generic_output_iterator (const generic_output_iterator & rhs)
    : item_ (rhs.item_), delim_ (rhs.delim_) { }
  
  // assignment - outputs to item_, followed by delim_
  template <typename Tp>
  generic_output_iterator & operator= (const Tp & rhs)
    { 
    item_ << rhs << delim_;  
    return *this;
    }  // end of operator=
  
  // dereference
  generic_output_iterator & operator* ()     { return *this; }
  // pre increment
  generic_output_iterator & operator++ ()    { return *this; }
  // post increment
  generic_output_iterator & operator++ (int) { return *this; }
};  // end of generic_output_iterator


typedef generic_output_iterator<tPlayer> player_ostream_iterator;


void DoShowFlags (tPlayer * p, istream & sArgs)
{
  tPlayer * ptarget = p->GetPlayer (sArgs, "Usage: showflags <who>");  // who
  NoMore (p, sArgs);  // check no more input
  *p << "Flags for " << ptarget->playername << " : ";
  std::copy (ptarget->flags.begin (), ptarget->flags.end (), player_ostream_iterator (*p, " "));
  *p << "\n"; 
      
} // end of DoShowFlags


The templated class generic_output_iterator now makes an output iterator for any type. The output type is automatic because that is templated inside the iterator.

Then the line in bold creates a player_ostream_iterator specifying the class to output to (tPlayer). Then the copy function in DoShowFlags can be simpler because we no longer need to specify that we are sending a string to the iterator.

[EDIT] Tidied up a bit to take an automatic output stream type (eg. string).
- Nick Gammon

www.gammon.com.au, www.mushclient.com
[Go to top] top
Posted by Nick Gammon   Australia  (18,770 posts)  [Biography] bio   Forum Administrator
Date Mon 04 Oct 2010 03:40 AM (UTC)  [ quote  ]
Message
I've added the output iterator to the Git repository:

http://github.com/nickgammon/tinymudserver/commit/98a4e65e14

- Nick Gammon

www.gammon.com.au, www.mushclient.com
[Go to top] top
Posted by Nick Gammon   Australia  (18,770 posts)  [Biography] bio   Forum Administrator
Date Mon 04 Oct 2010 03:06 AM (UTC)  [ quote  ]

Amended on Mon 04 Oct 2010 03:29 AM (UTC) by Nick Gammon

Message
Mudder said:

I'm having trouble creating a command that lists the current flags that a character has.


Here is an improved version. It took a bit of research to work out how to write an output iterator for a player, but I managed it. :)



// put this in player.h

template <typename T>
class player_output_iterator : public std::iterator <std::output_iterator_tag, void, void, void, void>
{
 protected:
   tPlayer &    player_;  // who we are outputting to
   const char * delim_;   // delimiter between each item
   
 public:
  // constructor
  player_output_iterator (tPlayer & p, const char* d = "")
    : player_ (p), delim_ (d) {}
  
  // copy constructor
  player_output_iterator (const player_output_iterator<T>& rhs)
   : player_ (rhs.player_), delim_ (rhs.delim_) {}
  
  // assignment
  player_output_iterator<T>& operator= (const T& rhs)
    { 
    player_ << rhs << delim_;  
    return *this;
    }
  
  // dereference - no operation, returns reference to itself
  player_output_iterator<T>& operator* ()     { return *this; }
  // increment   - no operation, returns reference to itself
  player_output_iterator<T>& operator++ ()    { return *this; }
  // increment   -  no operation, returns reference to itself
  player_output_iterator<T>& operator++ (int) { return *this; }
};  // end of player_output_iterator


// this is in commands.cpp

void DoShowFlags (tPlayer * p, istream & sArgs)
{
  tPlayer * ptarget = p->GetPlayer (sArgs, "Usage: showflags <who>");  // who
  NoMore (p, sArgs);  // check no more input
  *p << "Flags: for " << ptarget->playername << " : ";
  copy (ptarget->flags.begin (), ptarget->flags.end (), player_output_iterator<string> (*p, " "));
  *p << "\n"; 
      
} // end of DoShowFlags



Basically the output iterator is a class that gets instantiated in the copy call (line in bold). It remembers in its internal variable which player we want (the target of the output), and then implements operator= for assignment, so that each time the copy algorithm copies a string to the iterator, it then gets copied the the player, with the delimiter after it.

This might be lengthier now, but lets you iterate over other things, and copy other batches of stuff (inventory maybe) to the player, so it is a neater end-result.
- Nick Gammon

www.gammon.com.au, www.mushclient.com
[Go to top] top
Posted by Mudder   (7 posts)  [Biography] bio
Date Mon 04 Oct 2010 02:38 AM (UTC)  [ quote  ]

Amended on Mon 04 Oct 2010 03:09 AM (UTC) by Nick Gammon

Message
I suppose I wasn't entirely clear. Worstje did actually help me a little.

I've been away from coding for awhile so I was forgetting some basic things. I assumed tolower was modifying the original, instead of returning another. Newbie mistake!

Originally I couldn't see why the code wasn't working. I posted a working copy (the first code snip)

First Snip


messagemap [tolower (sMessageCode)] = FindAndReplace (sMessageText, "%r", "\r\n");

messagemap [tolower (sMessageCode)] = FindAndReplace (messagemap [tolower (sMessageCode)], "[/color]", "\e[0m");


then I posted a second snip and hoped for an explanation as to why it didn't work as the first did.

Second Snip


messagemap [tolower (sMessageCode)] = FindAndReplace (sMessageText, "%r", "\r\n");

messagemap [tolower (sMessageCode)] = FindAndReplace (sMessageText, "[/color]", "\e[0m");


The second part of both snips was where the question was.

The answer, of course, was that the original string wasn't being modified so I just kept reassigning values to the messagemap.

Since then I've been working to find a way to write this in a better way, slimming it down as much as possible. This is what I have.

void LoadHelps ()
{
  // format is: <code> <message>
  //  eg. motd Hi there!
  // Imbedded %r sequences will becomes new lines.
  ifstream fHelps (HELPS_FILE, ios::in);
  if (!fHelps)
    {
    cerr << "Could not open helps file: " << HELPS_FILE << endl;
    return;
    }

  while (!(fHelps.eof ()))
    {
    string sMessageCode, sMessageText;
    fHelps >> sMessageCode >> ws;
    getline (fHelps, sMessageText);
    if (!(sMessageCode.empty ()))
      sMessageText = FindAndReplace (sMessageText, "%r", "\r\n");
      sMessageText = FindAndReplace (sMessageText, "[/color]", "\e[0m");
      sMessageText = FindAndReplace (sMessageText, "[red]", "\e[0;31m");
      sMessageText = FindAndReplace (sMessageText, "[green]", "\e[0;32m");
      sMessageText = FindAndReplace (sMessageText, "[yellow]",  "\e[0;33m");
      sMessageText = FindAndReplace (sMessageText, "[blue]", "\e[0;34m");
      sMessageText = FindAndReplace (sMessageText, "[magenta]", "\e[0;35m");
      sMessageText = FindAndReplace (sMessageText, "[cyan]", "\e[0;36m");
      sMessageText = FindAndReplace (sMessageText, "[white]", "\e[0;37m");
      sMessageText = FindAndReplace (sMessageText, "[grey]", "\e[1;30m");
      sMessageText = FindAndReplace (sMessageText, "[RED]", "\e[1;31m");
      sMessageText = FindAndReplace (sMessageText, "[GREEN]", "\e[1;32m");
      sMessageText = FindAndReplace (sMessageText, "[YELLOW]", "\e[1;33m");
      sMessageText = FindAndReplace (sMessageText, "[BLUE]", "\e[1;34m");
      sMessageText = FindAndReplace (sMessageText, "[MAGENTA]", "\e[1;35m");
      sMessageText = FindAndReplace (sMessageText, "[CYAN]", "\e[1;36m");
      sMessageText = FindAndReplace (sMessageText, "[WHITE]", "\e[1;37m");
      messagemap [tolower (sMessageCode)] = sMessageText;

    } // end of read loop
} // end of LoadHelps


The above shows the context, the other snips were simply the bottom half.

[EDIT] Edited by Nick to put in some backslashes where required.
[Go to top] top
Posted by Worstje   Netherlands  (867 posts)  [Biography] bio
Date Mon 04 Oct 2010 01:54 AM (UTC)  [ quote  ]

Amended on Mon 04 Oct 2010 01:55 AM (UTC) by Worstje

Message
David Haley said:

Quote:
Because strings are immutable

Not in all languages, and in particular, not in C++.


Oops. Seems I am totally guilty of misinformation here. For some reason, I saw the code snippet, and after reading other topics involving Lua, I assumed it was Lua. My bad. :)

Still, assuming FindAndReplace does not modify the string in-place (which would be weird given the fact it returns stuff), the rest of my post holds.
[Go to top] top
Posted by David Haley   USA  (3,881 posts)  [Biography] bio   Moderator
Date Mon 04 Oct 2010 01:32 AM (UTC)  [ quote  ]
Message
Quote:
Because strings are immutable

Not in all languages, and in particular, not in C++. I think Mudder knows that program flow is linear. I don't know why it's not working since there is missing context and I don't know what the expected result is.

Mudder, you said that the first one doesn't work but the second one does, but then you ask why the second one doesn't work -- could you be more precise about which one is the one you expect to work but doesn't?
David Haley aka Ksilyan
Head Programmer,
Legends of the Darkstone

http://david.the-haleys.org
[Go to top] top
Posted by Worstje   Netherlands  (867 posts)  [Biography] bio
Date Mon 04 Oct 2010 01:25 AM (UTC)  [ quote  ]
Message
Mudder said:

... But what I don't quite understand is why the replacement works with the second piece of the code but if I try to use the first piece it doesn't.


      messagemap [tolower (sMessageCode)] = FindAndReplace (sMessageText, "%r", "\r\n");

      messagemap [tolower (sMessageCode)] = FindAndReplace (sMessageText, "[/color]", "\e[0m");


Why doesn't this work?


Because strings are immutable, and what you are assigning on the left side is not the same thing as you are using on the right side. When programming, do not forget that it is a 'timeline' from top to bottom; it is not math where everything is a statement of truth that is supposed to happen at the very same time.

To put it in a bit more trivial example without all the extra syntax cruft...

my_lucky_number = 42                      -- MY lucky number is 42.
your_lucky_number = my_lucky_number + 1   -- YOUR lucky number is mine plus one (43).
your_lucky_number = my_lucky_number - 10  -- YOUR lucky number is mine minus ten (32).
my_lucky_number = 1                       -- MY lucky number is 1.


You changing your mind on your lucky number does not change the fact that I still trust in the Hitchhiker's Guide of the Galaxy upto that point... until I get immersed into numerology. Then I choose one. But you still are stuck with 32 as your lucky number, since that is what you decided at that point in time.
[Go to top] top
Posted by Mudder   (7 posts)  [Biography] bio
Date Mon 04 Oct 2010 12:48 AM (UTC)  [ quote  ]
Message
Thank you for the DoShowFlags piece of code, I had given up for the time being.

I hope I'm not coming off as if I'm asking questions before experimenting and using some google. Because that certainly is not the case.

I'm trying to get a feel for this base and I think I mostly have it. The rest, I think, will be easy. ;)
[Go to top] top
Posted by Mudder   (7 posts)  [Biography] bio
Date Mon 04 Oct 2010 12:30 AM (UTC)  [ quote  ]
Message
So I am experimenting with putting in color in various ways and since there was already a nice piece of code written to replace the %r with \n I thought I would play with it.


      messagemap [tolower (sMessageCode)] = FindAndReplace (sMessageText, "%r", "\r\n");

      messagemap [tolower (sMessageCode)] = FindAndReplace (messagemap [tolower (sMessageCode)], "[/color]", "\e[0m");


Someone already asked the question that gave me the part of the code that replaces [/color] - But what I don't quite understand is why the replacement works with the second piece of the code but if I try to use the first piece it doesn't.


      messagemap [tolower (sMessageCode)] = FindAndReplace (sMessageText, "%r", "\r\n");

      messagemap [tolower (sMessageCode)] = FindAndReplace (sMessageText, "[/color]", "\e[0m");


Why doesn't this work?
[Go to top] top
Posted by Nick Gammon   Australia  (18,770 posts)  [Biography] bio   Forum Administrator
Date Sun 03 Oct 2010 11:14 PM (UTC)  [ quote  ]
Message
This worked for me, there might be an easier way:


void DoShowFlags (tPlayer * p, istream & sArgs)
{
  tPlayer * ptarget = p->GetPlayer (sArgs, "Usage: showflags <who>");  // who
  NoMore (p, sArgs);  // check no more input

  *p << "Flags for " << ptarget->playername << " : ";

  // loop through each flag  
  for (std::set<string, ciLess>::const_iterator it = ptarget->flags.begin ();
       it != ptarget->flags.end ();
       it++)
     *p << *it << " ";
  
  *p << "\n"; 
      
} // end of DoShowFlags

- Nick Gammon

www.gammon.com.au, www.mushclient.com
[Go to top] top
Posted by Nick Gammon   Australia  (18,770 posts)  [Biography] bio   Forum Administrator
Date Sun 03 Oct 2010 10:43 PM (UTC)  [ quote  ]
Message
From the source, where it saves the player flags:


 copy (flags.begin (), flags.end (), ostream_iterator<string> (f, " "));


A variation on that should do it, as that was all it took to write them to the player file.
- Nick Gammon

www.gammon.com.au, www.mushclient.com
[Go to top] top
Posted by David Haley   USA  (3,881 posts)  [Biography] bio   Moderator
Date Sun 03 Oct 2010 10:08 PM (UTC)  [ quote  ]
Message
Why not something like:

for flag in flag list:
  if ch has flag:
    print "ch has flag '" + flag + "'"
David Haley aka Ksilyan
Head Programmer,
Legends of the Darkstone

http://david.the-haleys.org
[Go to top] top
Posted by Mudder   (7 posts)  [Biography] bio
Date Sun 03 Oct 2010 09:17 PM (UTC)  [ quote  ]
Message
I'm having trouble creating a command that lists the current flags that a character has.

I'd rather just cycle through and spit out each flag, rather than checking for each flag like this:

if (HaveFlag (can_shutdown))
if (HaveFlag (can_goto))


That just seems unnecessary.
[Go to top] top

The dates and times for posts above are shown in Universal Co-ordinated Time (UTC).

To show them in your local time you can join the forum, and then set the 'time correction' field in your profile to the number of hours difference between your location and UTC time.

51,144 views.

This is page 1, subject is 8 pages long: 1 2  3  4  5  6  7  8  [Next page]

[Reply to this subject]  Reply to this subject   [New subject]  Start a new subject   [Refresh] Refresh page

Go to topic:           Search the forum

[Go to top] top

[Home]

Written by Nick Gammon - 5K

Comments to: Gammon Software support
[RH click to get RSS URL] Forum RSS feed ( http://www.gammon.com.au/rss/forum.xml )

[Best viewed with any browser - 2K]    [Internet Contents Rating Association (ICRA) - 2K]    [Web site powered by FutureQuest.Net]