[Home] [Downloads] [Search] [Help/forum]

Gammon Software Solutions forum

See www.mushclient.com/spam for dealing with forum spam. Please read the MUSHclient FAQ!

[Folder]  Entire forum
-> [Folder]  Programming
. -> [Folder]  General
. . -> [Subject]  Help with a numbers solution
Home  |  Users  |  Search  |  FAQ
Username:
Register forum user name
Password:
Forgotten password?
(New message)
Subject: Help with a numbers solution
Name:
Your forum user name.
Register forum user name
Password:
Your forum password.
Forgotten password?
Message:
Message to be posted (in English, please).
Forum codes:
Check this if your message uses 'forum codes' or templates (auto-detected for new posts).
Forum codes Templates

Save this message ...

Subject review (reverse sequence)

Posted by Twisol   USA  (2,229 posts)  [Biography] bio
Date Sun 06 May 2012 12:54 AM (UTC)  [ quote  ]
Message
Right, but the int -> long conversion is lossless. Good point about int and long in a 32-bit environment. Since it's probably a safe bet that this was written for a 32-bit computer, I'd say it's totally safe to remove.
'Soludra' on Achaea

Blog: http://jonathan.com/
GitHub: http://github.com/Twisol
[Go to top] top
Posted by Fiendish   USA  (848 posts)  [Biography] bio   Global Moderator
Date Sat 05 May 2012 02:03 PM (UTC)  [ quote  ]

Amended on Sat 05 May 2012 02:07 PM (UTC) by Fiendish

Message
Twisol said:

It converts from a long to an int, stopping over in stringland in between.
It then casts back to long. It's all kind of silly. In a 32 bit environment int and long are the same thing anyway in C.
http://aardwolfclientpackage.googlecode.com/
[Go to top] top
Posted by Twisol   USA  (2,229 posts)  [Biography] bio
Date Sat 05 May 2012 08:18 AM (UTC)  [ quote  ]
Message
It converts from a long to an int, stopping over in stringland in between. I don't think there's any harm in removing it, though you might want to find out how itoa handles values that are out-of-range. A simple cast might behave differently.
'Soludra' on Achaea

Blog: http://jonathan.com/
GitHub: http://github.com/Twisol
[Go to top] top
Posted by Fiendish   USA  (848 posts)  [Biography] bio   Global Moderator
Date Sat 05 May 2012 12:59 AM (UTC)  [ quote  ]

Amended on Sat 05 May 2012 01:02 AM (UTC) by Fiendish

Message
Daniel Spain said:

Fiendish said:

Quote:
atoi(ltoa(...))

What was the point of this?

well when i got the codebase it was already a completed game, written in bcc 3.1 i finalized it and ported it to bcc 4.5 then bbsing went dormant we all moved on to other things well i picked it back up a few years ago and ported it to bcc 5.01 then to 5.5.1 and never had to touch most the code except maybe make a few changes just to get rid of annoying compiler warnings but with making it standalone i hit alot of errors just on things like the above code which is why i asked. i am no career developer by far all my knowledge has came from trial and error on this same codebase since the mid 90's and well since it worked won;t no need in fixing it and this porting project broke it so i had to fix it.


I meant very specifically what is the point of taking a number, converting it to a string, and then converting the string back to a number? :)

Like 5->"5"->5

It looks to me like the original way had no value so you didn't lose anything by removing it.
http://aardwolfclientpackage.googlecode.com/
[Go to top] top
Posted by Daniel Spain   (15 posts)  [Biography] bio
Date Fri 04 May 2012 08:39 AM (UTC)  [ quote  ]
Message
Fiendish said:

Quote:
atoi(ltoa(...))

What was the point of this?




well when i got the codebase it was already a completed game, written in bcc 3.1 i finalized it and ported it to bcc 4.5 then bbsing went dormant we all moved on to other things well i picked it back up a few years ago and ported it to bcc 5.01 then to 5.5.1 and never had to touch most the code except maybe make a few changes just to get rid of annoying compiler warnings but with making it standalone i hit alot of errors just on things like the above code which is why i asked. i am no career developer by far all my knowledge has came from trial and error on this same codebase since the mid 90's and well since it worked won;t no need in fixing it and this porting project broke it so i had to fix it.
[Go to top] top
Posted by Fiendish   USA  (848 posts)  [Biography] bio   Global Moderator
Date Fri 04 May 2012 03:39 AM (UTC)  [ quote  ]
Message
Quote:
atoi(ltoa(...))

What was the point of this?

http://aardwolfclientpackage.googlecode.com/
[Go to top] top
Posted by Daniel Spain   (15 posts)  [Biography] bio
Date Thu 03 May 2012 07:09 PM (UTC)  [ quote  ]
Message
hello all back in the 90's using bcc 3.1 i wrote a mud for a bbs software and here recently i have been porting it to a standalone using Nick's barebones mud server.

i hit a compile error with this math function.


long ep2 = atoi(ltoa(((p->exp/(DEFEPL+axp))+1)));


to fix the compile error i adjusted it like so:


long ep2 = ((p->exp/(DEFEPL+axp))+1);


will this suffice or could i lose any of the value in the conversion?
[Go to top] top

The dates and times for posts above are shown in Universal Co-ordinated Time (UTC).

To show them in your local time you can join the forum, and then set the 'time correction' field in your profile to the number of hours difference between your location and UTC time.

739 views.

[Reply to this subject]  Reply to this subject   [New subject]  Start a new subject   [Refresh] Refresh page

Go to topic:           Search the forum

[Go to top] top

[Home]

Written by Nick Gammon - 5K

Comments to: Gammon Software support
[RH click to get RSS URL] Forum RSS feed ( http://www.gammon.com.au/rss/forum.xml )

[Best viewed with any browser - 2K]    [Internet Contents Rating Association (ICRA) - 2K]    [Web site powered by FutureQuest.Net]