[Home] [Downloads] [Search] [Help/forum]

Gammon Software Solutions forum

See www.mushclient.com/spam for dealing with forum spam. Please read the MUSHclient FAQ!

[Folder]  Entire forum
-> [Folder]  MUSHclient
. -> [Folder]  General
. . -> [Subject]  Omit extra blank lines
Home  |  Users  |  Search  |  FAQ
Username:
Register forum user name
Password:
Forgotten password?
(New message)
Subject: Omit extra blank lines
Name:
Your forum user name.
Register forum user name
Password:
Your forum password.
Forgotten password?
Message:
Message to be posted (in English, please).
Forum codes:
Check this if your message uses 'forum codes' or templates (auto-detected for new posts).
Forum codes Templates

Save this message ...

Subject review (reverse sequence)

Pages: 1 2  

Posted by Digs   USA  (17 posts)  [Biography] bio
Date Thu 14 Jun 2012 05:16 PM (UTC)  [ quote  ]
Message
Performance is great - no issues.

The OnPluginScreenDraw callback is in the same line processing chain as OnPluginLineReceived and trigger matching (see http://www.gammon.com.au/forum/bbshowpost.php?bbsubject_id=6554). It has an added performance benefit because it's only called once per visible line (including notes and commands), unlike OnPluginLineReceived and triggers which process every incoming line.

It does appear that OnPluginScreenDraw is called too late to do anything with the current line, but it works just fine to enable a line-omitting trigger for the following line. ;-)
[Go to top] top
Posted by Worstje   Netherlands  (867 posts)  [Biography] bio
Date Thu 14 Jun 2012 11:02 AM (UTC)  [ quote  ]
Message
Nice. I hadn't even considered OnPluginScreenDraw. However, what does that behave like when you scroll up and down, pgup, pgdown and so forth?
[Go to top] top
Posted by Digs   USA  (17 posts)  [Biography] bio
Date Thu 14 Jun 2012 12:22 AM (UTC)  [ quote  ]
Message
Success! Thanks for the help.

This plugin omits extra blank lines from the output window (excluding blank lines generated from notes). For instance, if there are 3 blank lines in a row, it will remove 2 of them.


<?xml version="1.0" encoding="iso-8859-1"?>
<!DOCTYPE muclient>
<!-- Saved on Tuesday, June 12, 2012, 9:29 AM -->
<!-- MuClient version 4.81 -->

<!-- Plugin "Omit_Extra_Blank_Lines" generated by Plugin Wizard -->

<muclient>
<plugin
   name="Omit_Extra_Blank_Lines"
   author="Digs"
   id="9742160fe2a5ccb8e35478f1"
   language="Lua"
   purpose="Omits extra blank lines from output."
   date_written="2012-06-12 09:29:45"
   version="1.1"
   >
<description trim="y">
<![CDATA[
Omits extra blank lines from output.
For example, given 3 blank lines in a row, 2 will be deleted.
]]>
</description>

</plugin>

<triggers>
  <trigger
   enabled="n"
   match="^$"
   name="omit_blank"
   omit_from_output="y"
   regexp="y"
   sequence="1"
  >
  </trigger>
</triggers>

<script>
<![CDATA[

function OnPluginScreendraw (type, log, line)
  if line == "" then
    EnableTrigger("omit_blank", true)
  else
    EnableTrigger("omit_blank", false)
  end
end

]]>
</script> 

</muclient>
[Go to top] top
Posted by Digs   USA  (17 posts)  [Biography] bio
Date Tue 12 Jun 2012 10:42 PM (UTC)  [ quote  ]
Message
Point #3

Unfortunately, it isn't practical to use multi-line triggers within the plugin Aardwolf_Consider_Window as a solution. It is not possible to know beforehand, which of the lines omitted by the single-line triggers will be followed by a blank line. The game output for "consider all" varies. Also, modifying the "^nhm$" trigger so it matches 2 lines breaks things.

1st "consider all":


(Red Aura) You would stomp A troglodyte into the ground.
(Red Aura) You would stomp Glittering cavern dust into the ground.
You would stomp A rock creature into the ground.
You would stomp A slimy rock into the ground.

nhm


2nd "consider all":


(Red Aura) You would stomp A troglodyte into the ground.
(Red Aura) You would stomp Glittering cavern dust into the ground.
You would stomp A rock creature into the ground.
You would stomp A slimy rock into the ground.
You would stomp A fossil into the ground.
You would stomp A fossil into the ground.

nhm
[Go to top] top
Posted by Digs   USA  (17 posts)  [Biography] bio
Date Tue 12 Jun 2012 09:41 PM (UTC)  [ quote  ]
Message
Point #3

The extra blank line left by omitting the echoed text is not so strange. The blank line following the echo just needs to be removed too. Here's a modified version of the example that creates no extra blank lines. I'll make the changes to my modified plugin:


<?xml version="1.0" encoding="iso-8859-1"?>
<!DOCTYPE muclient>
<!-- Saved on Tuesday, June 12, 2012, 11:17 AM -->
<!-- MuClient version 4.81 -->

<!-- Plugin "EchoTest" generated by Plugin Wizard -->

<muclient>
<plugin
   name="EchoTest"
   author="Digs"
   id="7d2b31fb5db49f949d802307"
   language="Lua"
   purpose="TEST: SendNoEcho, and then remove the echo and the next blank line."
   save_state="y"
   date_written="2012-06-12 11:14:05"
   requires="4.81"
   version="1.0"
   >
<description trim="y">
<![CDATA[
Send an echo with SendNoEcho. 
Omit the echo, and the next blank line to avoid an extra blank line.
]]>
</description>

</plugin>


<!--  Get our standard constants -->

<include name="constants.lua"/>

<!--  Triggers  -->

<triggers>
  <trigger
   enabled="y"
   keep_evaluating="y"
   match="^[ Exits"
   regexp="y"
   script="send_echo"
   send_to="12"
   sequence="100"
  >
  </trigger>
  <trigger
   enabled="y"
   lines_to_match="2"
   match="^EchoTest\n\z"
   multi_line="y"
   regexp="y"
   script="omit_echo_and_blank"
   send_to="12"
   sequence="100"
  >
  </trigger>
</triggers>

<script>
<![CDATA[

function send_echo ()
  SendNoEcho ("echo EchoTest")
end

function omit_echo_and_blank ()
  DeleteLines(2)
end

]]>
</script> 

</muclient>
[Go to top] top
Posted by Digs   USA  (17 posts)  [Biography] bio
Date Tue 12 Jun 2012 08:11 PM (UTC)  [ quote  ]
Message
Looking back over the posts, I think this subject has become a bit muddied. My bad. Sorry that I made you insane Worstje. I shouldn't post when I'm tired. :-)

To clarify, there are several distinct but related points:
#1. I never want more than one visible blank line between the lines of text in the output window.
#2. I'd like to be able to match all visible lines of text in the output window.
#3. My modified Aardwolf_Consider_Window plugin is causing extra blank lines to appear in the output window.


Point #1:

As mentioned, extra blank lines in the output can be caused by a number of things. While it would be ideal to always fix the cause instead of the symptom, that is not always easy or possible. I think Nick Gammon validated this point of view when he made his Omit_Blank_Lines plugin (http://www.gammon.com.au/forum/?id=8768). It works perfectly, but I prefer normal spacing.

The dual trigger example in post 6 is an ugly hack. I only posted it because an example was requested. While somewhat functional, it was a bad choice for discussion.

If point #2 can be addressed, then point #1 will be easily dealt with.


Point #2:

Is there a way to match all visible non-blank lines? The pattern ".+" matches both visible and omitted lines.

@Fiendish: I'm not trying to remove any lines in the example in post 5. I was showing that ".+" matches both visible and omitted lines, so it won't work as a solution for point #1.


Points #1 & #2, Example:

Here's a good, clean example of a plugin that attempts to omit extra blank spaces. It doesn't work because the third trigger named "not_a_blank_line" matches both visible and omitted lines. If you don't have any extra blank spaces to test this with, see the example for point #3.


<?xml version="1.0" encoding="iso-8859-1"?>
<!DOCTYPE muclient>
<!-- Saved on Tuesday, June 12, 2012, 9:29 AM -->
<!-- MuClient version 4.81 -->

<!-- Plugin "Omit_Extra_Blank_Lines" generated by Plugin Wizard -->

<muclient>
<plugin
   name="Omit_Extra_Blank_Lines"
   author="Digs"
   id="9742160fe2a5ccb8e35478f1"
   language="Lua"
   purpose="Omits extra blank lines from output."
   date_written="2012-06-12 09:29:45"
   requires="4.81"
   version="1.0"
   >
<description trim="y">
<![CDATA[
Omits extra blank lines from output.

NOTE: The option "File > Global Preferences > Regular expressions can match on an empty string",
      must be checked.
]]>
</description>

</plugin>


<!--  Get our standard constants -->

<include name="constants.lua"/>

<!--  Triggers  -->

<triggers>
  <trigger
   enabled="y"
   match="^$"
   name="first_blank_line"
   regexp="y"
   script="start_omitting_blank_lines"
   send_to="12"
   sequence="2"
  >
  </trigger>
  <trigger
   enabled="n"
   keep_evaluating="n"
   match="^$"
   name="gag_blank_lines"
   omit_from_output="y"
   regexp="y"
   sequence="1"
  >
  </trigger>
  <trigger
   enabled="n"
   keep_evaluating="y"
   match="."
   name="not_a_blank_line"
   regexp="y"
   script="stop_omitting_blank_lines"
   send_to="12"
   sequence="10000"
  >
  </trigger>
</triggers>

<script>
<![CDATA[

function start_omitting_blank_lines ()
  EnableTrigger("gag_blank_lines", true)
  EnableTrigger("not_a_blank_line", true)
end

function stop_omitting_blank_lines ()
  EnableTrigger("gag_blank_lines", false)
  EnableTrigger("not_a_blank_line", false)
end

]]>
</script> 

</muclient>



Point #3

The Aardwolf_Consider_Window plugin uses this line in its code: Send ("echo nhm"). This is rather spammy, so I changed it to: SendNoEcho ("echo nhm"). The plugin triggers on this echo to refresh its window, and it does this often with the setting "conw auto". The echo is omitted, but strangely a blank line is left behind. Use the following example to easily reproduce this behavior (change the first trigger's match to something reproducible). Thoughts?


<?xml version="1.0" encoding="iso-8859-1"?>
<!DOCTYPE muclient>
<!-- Saved on Tuesday, June 12, 2012, 11:17 AM -->
<!-- MuClient version 4.81 -->

<!-- Plugin "EchoTest" generated by Plugin Wizard -->

<muclient>
<plugin
   name="EchoTest"
   author="Digs"
   id="7d2b31fb5db49f949d802307"
   language="Lua"
   purpose="TEST: SendNoEcho + omit the echo = extra space in output."
   save_state="y"
   date_written="2012-06-12 11:14:05"
   requires="4.81"
   version="1.0"
   >
<description trim="y">
<![CDATA[
Send an echo with SendNoEcho. 
Omit the echo.
There is then an extra space in the output window.
]]>
</description>

</plugin>


<!--  Get our standard constants -->

<include name="constants.lua"/>

<!--  Triggers  -->

<triggers>
  <trigger
   enabled="y"
   keep_evaluating="y"
   match="^[ Exits"
   regexp="y"
   script="send_echo"
   send_to="12"
   sequence="100"
  >
  </trigger>
  <trigger
   enabled="y"
   keep_evaluating="n"
   match="^EchoTest$"
   omit_from_output="y"
   regexp="y"
   sequence="100"
  >
  </trigger>
</triggers>

<script>
<![CDATA[

function send_echo ()
  SendNoEcho ("echo EchoTest")
end

]]>
</script> 

</muclient>
[Go to top] top
Posted by Worstje   Netherlands  (867 posts)  [Biography] bio
Date Tue 12 Jun 2012 07:17 PM (UTC)  [ quote  ]
Message
Fiendish, look at the trigger above the post: all lines prefixed with ~ are trigger notes that also show the stuff that's been gagged.
[Go to top] top
Posted by Fiendish   USA  (851 posts)  [Biography] bio   Global Moderator
Date Tue 12 Jun 2012 01:48 PM (UTC)  [ quote  ]

Amended on Tue 12 Jun 2012 02:16 PM (UTC) by Fiendish

Message
Digs said:

Here's some of the output. The line's that start with "~ " are the echoed lines. It's easy to see all the "blank" lines that were echoed:

"Posted: Hard Hat Zone."  
~ "Posted: Hard Hat Zone."  

~ <MAPSTART>
~ North of the Grand Plaza
~  
~  
~                             
~          [?] <!> [?]      
~      -------     -------     
~      - - - - < > -!- - -  
~      -------     -------     
~             |.!.|         
~                 |            
~          [?] .#.|         
~      ---                     
~     |##> (~) (!) (!)      
~      ---             ---     
~      - - (~) . > (~) - -  
~      ---             ---     
~     |##> (!) (~) (~) ##>| 
~      ---             ---     
~  
~ [ Exits: N S W * ]
~ <MAPEND>
[ Exits: north south west other ]
~ [ Exits: north south west other ]
(Golden Aura) A stout dwarf, Wesnir, walks slowly, admiring the views of Aylor.
~ (Golden Aura) A stout dwarf, Wesnir, walks slowly, admiring the views of Aylor.
(Red Aura) A goblin carries a large money sack that reads 'Tax'.
~ (Red Aura) A goblin carries a large money sack that reads 'Tax'.
A gnomish incinerator bot is here, belching smoke and fire.
~ A gnomish incinerator bot is here, belching smoke and fire.

~ (Golden Aura) You would stomp A touring dwarf into the ground.
~ (Red Aura) You would stomp An aylorian tax collector into the ground.
~ You would be completely annihilated by Incinerator bot!


I could post one of my test plugins, but they all suffer from the same issue - I can't find a way to match only visible, non-blank lines. My most successful versions just try to work around this issue.



So in this example which lines exactly do you want to remove? There is an in-game command 'shortmap' for unpadding the automap, but IMO what you think you want out of this is a really bad idea. The map loses any placement consistency if you removing the padding, which makes it pretty hard to use because your eyes have to bounce around too much. That's why it is padded by default. Nowhere else in your example do you have two consecutive blank lines.

And why are you showing map tags in your main output? I would think you'd either use them or turn them off.


Worstje said:
Okay, re-reading this thread five times has made me catch on to what you want. All the details with triggers and regular expressions made me blind to what you wanted to achieve, and I'm sorry it took me a while to grasp that. :)

Your primary problem is most likely that the output window is more than mud output: scripted notes and (if turned on) sent commands are also displayed in it. Those are never sent through the trigger system, because obviously it isn't game output.

Thus Note()-outputting empty lines would defeat any system you have. While I think I can come up with something that works reasonably well, I think you are going about your problem entirely the wrong way, where you are trying to counter the effects of (for example) a leaky roof by putting a bucket underneath rather than properly fixing it. Any bucket-like solution I concoct will only give more headaches in the long run, I can promise you that.

Where do your extra empty lines come from? Why are they happening? Are they side-effects from other omitted text? Is it crappy game output? Do you have scripts that output too much?
Worstje is likely correct. The server to my knowledge never sends multiple blank lines in a row except for specific cases where it is actually beneficial to have them like inside the map tags.
http://aardwolfclientpackage.googlecode.com/
[Go to top] top
Posted by Worstje   Netherlands  (867 posts)  [Biography] bio
Date Tue 12 Jun 2012 10:38 AM (UTC)  [ quote  ]

Amended on Tue 12 Jun 2012 10:40 AM (UTC) by Worstje

Message
I don't have the sanity of mind right now to go into depth on trying to figure your problem out (that's for tomorrow), but I can advise you to use sequence="5" for that trigger. That will pretty much ensure it is executed first. ('1' would still be better technically, but the point is to be before the default 100, and before any other plugins that likely want to pre-empt the defaults. With '5' you leave yourself some room if ever there is a situation you don't want notepadded.)

G'nite for today. :-)
[Go to top] top
Posted by Digs   USA  (17 posts)  [Biography] bio
Date Tue 12 Jun 2012 08:41 AM (UTC)  [ quote  ]
Message
No worries! I'm just happy to have someone to bounce things off of. Thanks! ;-)

The semi-solution I posted is ugly, but it's one of my better functioning tests. I tried 14 instead of 12, but didn't see any difference. It's a dead end though, so let's not waste time on it.

If I could match all the visible, non-blank lines in the output window then this would be a non-issue and the solution would be a very simple one. Like I said, PCRE has an option to invert matches - a trigger option that allows for this would be great. If there's another simple option, I'd be interested.


That said, you're right, it is usually better to treat the cause and not the symptom.

I've looked into it, a good portion of the extra empty lines are coming from Aardwolf_Consider_Window (http://www.gammon.com.au/forum/bbshowpost.php?id=9681). Especially with the setting "conw auto". I'll look into it more, and will post there if I have questions about it.


NOTE: This seems to be a handy trigger for seeing the non-gagged output in a notepad window. It works great side-by-side with the regular output window:


<triggers>
  <trigger
   enabled="y"
   keep_evaluating="y"
   match="^.*$"
   regexp="y"
   send_to="5"
   sequence="100"
  >
  <send>%0</send>
  </trigger>
</triggers>



[Go to top] top
Posted by Worstje   Netherlands  (867 posts)  [Biography] bio
Date Tue 12 Jun 2012 07:03 AM (UTC)  [ quote  ]
Message
We're cross-posting a bit now.

Try setting your trigger to Send to: 'Script (after omit)', number 14. Script works really wonky if you use it the way you use it in the old 12 mode. (Another reason why I avoid scripting like that, but I digress.)
[Go to top] top
Posted by Worstje   Netherlands  (867 posts)  [Biography] bio
Date Tue 12 Jun 2012 07:00 AM (UTC)  [ quote  ]
Message
Okay, re-reading this thread five times has made me catch on to what you want. All the details with triggers and regular expressions made me blind to what you wanted to achieve, and I'm sorry it took me a while to grasp that. :)

Your primary problem is most likely that the output window is more than mud output: scripted notes and (if turned on) sent commands are also displayed in it. Those are never sent through the trigger system, because obviously it isn't game output.

Thus Note()-outputting empty lines would defeat any system you have. While I think I can come up with something that works reasonably well, I think you are going about your problem entirely the wrong way, where you are trying to counter the effects of (for example) a leaky roof by putting a bucket underneath rather than properly fixing it. Any bucket-like solution I concoct will only give more headaches in the long run, I can promise you that.

Where do your extra empty lines come from? Why are they happening? Are they side-effects from other omitted text? Is it crappy game output? Do you have scripts that output too much?
[Go to top] top
Posted by Digs   USA  (17 posts)  [Biography] bio
Date Tue 12 Jun 2012 06:48 AM (UTC)  [ quote  ]
Message
Here's a trigger only version. It actually works fairly well, but it removes too many blank lines.

The first trigger matches and removes all blank lines. It counts the number of blank lines, and adds back a single blank line when the count is "1":


  <trigger
   enabled="y"
   group="GagBlanks"
   match="^$"
   omit_from_output="y"
   regexp="y"
   send_to="12"
   sequence="100"
  >
  <send>local BlankNum

BlankNum = GetVariable("BlankNum")

if BlankNum == nil then
  BlankNum = 0
end

BlankNum = BlankNum + 1

if BlankNum == 1 then
  Note ("")
end

SetVariable ("BlankNum", BlankNum)
SetVariable ("IsBlank", "true")</send>
  </trigger>
</triggers>


The second trigger attempts to match on lines that are not blank. It then resets the blank lines counter.


<triggers>
  <trigger
   enabled="y"
   group="GagBlanks"
   match="."
   regexp="y"
   send_to="12"
   sequence="101"
  >
  <send>local IsBlank

IsBlank = GetVariable("IsBlank")

if IsBlank == "false" or IsBlank == nil then
  SetVariable ("BlankNum", 0)
end

SetVariable ("IsBlank", "false")</send>
  </trigger>
</triggers>
[Go to top] top
Posted by Digs   USA  (17 posts)  [Biography] bio
Date Tue 12 Jun 2012 06:16 AM (UTC)  [ quote  ]

Amended on Tue 12 Jun 2012 06:56 AM (UTC) by Digs

Message
Yes, I've printed the line parameter. To keep things simple, I created a trigger using "^.+$". It sends the matched line back to the output. It echos all visible lines, and non-visible lines.


<triggers>
  <trigger
   enabled="y"
   keep_evaluating="y"
   match="^.+$"
   regexp="y"
   send_to="2"
   sequence="100"
  >
  <send>~ %0</send>
  </trigger>
</triggers>


Here's some of the output. The line's that start with "~ " are the echoed lines. It's easy to see all the "blank" lines that were echoed:


"Posted: Hard Hat Zone."  
~ "Posted: Hard Hat Zone."  

~ <MAPSTART>
~ North of the Grand Plaza
~  
~  
~                             
~          [?] <!> [?]      
~      -------     -------     
~      - - - - < > -!- - -  
~      -------     -------     
~             |.!.|         
~                 |            
~          [?] .#.|         
~      ---                     
~     |##> (~) (!) (!)      
~      ---             ---     
~      - - (~) . > (~) - -  
~      ---             ---     
~     |##> (!) (~) (~) ##>| 
~      ---             ---     
~  
~ [ Exits: N S W * ]
~ <MAPEND>
[ Exits: north south west other ]
~ [ Exits: north south west other ]
(Golden Aura) A stout dwarf, Wesnir, walks slowly, admiring the views of Aylor.
~ (Golden Aura) A stout dwarf, Wesnir, walks slowly, admiring the views of Aylor.
(Red Aura) A goblin carries a large money sack that reads 'Tax'.
~ (Red Aura) A goblin carries a large money sack that reads 'Tax'.
A gnomish incinerator bot is here, belching smoke and fire.
~ A gnomish incinerator bot is here, belching smoke and fire.

~ (Golden Aura) You would stomp A touring dwarf into the ground.
~ (Red Aura) You would stomp An aylorian tax collector into the ground.
~ You would be completely annihilated by Incinerator bot!


I could post one of my test plugins, but they all suffer from the same issue - I can't find a way to match only visible, non-blank lines. My most successful versions just try to work around this issue.
[Go to top] top
Posted by Worstje   Netherlands  (867 posts)  [Biography] bio
Date Tue 12 Jun 2012 05:14 AM (UTC)  [ quote  ]
Message
For Trigger3, have you tried printing the line (second) parameter? Also, can you paste it in its entirety?

I suspect you are doing something wrong and the line you think is empty is, in fact, no empty.

Alternatively, can you try ^.+$ for your match pattern? Or try ^[^\n]+$ ?
[Go to top] top

The dates and times for posts above are shown in Universal Co-ordinated Time (UTC).

To show them in your local time you can join the forum, and then set the 'time correction' field in your profile to the number of hours difference between your location and UTC time.

1,178 views.

This is page 1, subject is 2 pages long: 1 2  [Next page]

[Reply to this subject]  Reply to this subject   [New subject]  Start a new subject   [Refresh] Refresh page

Go to topic:           Search the forum

[Go to top] top

[Home]

Written by Nick Gammon - 5K

Comments to: Gammon Software support
[RH click to get RSS URL] Forum RSS feed ( http://www.gammon.com.au/rss/forum.xml )

[Best viewed with any browser - 2K]    [Internet Contents Rating Association (ICRA) - 2K]    [Web site powered by FutureQuest.Net]