Notice: Any messages purporting to come from this site telling you that your password has expired, or that you need to verify your details, confirm your email, resolve issues, making threats, or asking for money, are
spam. We do not email users with any such messages. If you have lost your password you can obtain a new one by using the
password reset link.
Entire forum
➜ MUSHclient
➜ Bug reports
➜ Ctrl+S doesn't clear dirty flag.
|
Ctrl+S doesn't clear dirty flag.
|
Posting of new messages is disabled at present.
Refresh page
| Posted by
| WillFa
USA (525 posts) Bio
|
| Date
| Wed 07 Jul 2010 08:22 AM (UTC) Amended on Wed 07 Jul 2010 08:33 AM (UTC) by WillFa
|
| Message
| Press Ctrl+S to save your world. Press Ctrl+F4 immediately afterwards to close the world. You'll still get prompted that "Variables only have changed. Would you like to save?"
"I just did!"
(This still happens on 4.52) | | Top |
|
| Posted by
| Nick Gammon
Australia (23,122 posts) Bio
Forum Administrator |
| Date
| Reply #1 on Wed 07 Jul 2010 09:57 PM (UTC) |
| Message
| Can't reproduce that. Are you sure that the saving process doesn't change things? For example if the "on save" handler changed a variable, then it might become dirty again.
Or a timer might fire in the short interval after you saved it, and changed something.
Try doing a save, renaming the saved world file, then closing and accepting the offer to save again, then do a diff to see what changes there are between the two files. |
- Nick Gammon
www.gammon.com.au, www.mushclient.com | | Top |
|
| Posted by
| Twisol
USA (2,257 posts) Bio
|
| Date
| Reply #2 on Wed 07 Jul 2010 09:58 PM (UTC) |
| Message
|
Nick Gammon said:
For example if the "on save" handler changed a variable, then it might become dirty again.
That seems fishy. Shouldn't the client only save -after- the on-save handlers are called? |
'Soludra' on Achaea
Blog: http://jonathan.com/
GitHub: http://github.com/Twisol | | Top |
|
| Posted by
| Nick Gammon
Australia (23,122 posts) Bio
Forum Administrator |
| Date
| Reply #3 on Wed 07 Jul 2010 10:25 PM (UTC) |
| Message
| Lol - the flag that said that the variables have changed was never cleared. Thus, once you change a variable it *always* asked you to save the world. I must admit that had niggled at the back of my brain for a while.
Fixed in version 4.53.
The reason is, it used to just set the "dirty" flag - which the OnSave cleared. However once it set its own "variables have changed" flag, this was never cleared, due to a small oversight.
No-one else noticed this either *cough* Twisol *cough*. |
- Nick Gammon
www.gammon.com.au, www.mushclient.com | | Top |
|
| Posted by
| Twisol
USA (2,257 posts) Bio
|
| Date
| Reply #4 on Wed 07 Jul 2010 10:29 PM (UTC) |
| Message
| Pah! I was focused elsewhere. >_>
(Speaking of which, I have a couple other fixes you can expect later!) |
'Soludra' on Achaea
Blog: http://jonathan.com/
GitHub: http://github.com/Twisol | | Top |
|
The dates and times for posts above are shown in Universal Co-ordinated Time (UTC).
To show them in your local time you can join the forum, and then set the 'time correction' field in your profile to the number of hours difference between your location and UTC time.
14,767 views.
Posting of new messages is disabled at present.
Refresh page
![[Go to top]](/images/gototop.gif)
top