Register forum user name Search FAQ

Gammon Forum

Notice: Any messages purporting to come from this site telling you that your password has expired, or that you need to verify your details, confirm your email, resolve issues, making threats, or asking for money, are spam. We do not email users with any such messages. If you have lost your password you can obtain a new one by using the password reset link.

Due to spam on this forum, all posts now need moderator approval.

 Entire forum ➜ SMAUG ➜ SMAUG coding ➜ Smaug compiling using g++
Smaug compiling using g++

It is now over 60 days since the last post. This thread is closed.     Refresh page

Pages: 1 2  

Posted by Robert Powell   Australia  (367 posts)  Bio
Date Thu 06 Dec 2007 10:16 PM (UTC)
Message
I have a need to make my source compile in g++, i ran it through just to see how many errors there would be and see how much work is involved.

I know others here have done this sort of madness before and was after some suggestions on the best way to approach it.

The reward for me doing this is a totally out of this world prog system thats been written for smaug using C++ methods.
Just a guy having a bit of fun. Nothing more, nothing less, I do not need I WIN to feel validated.
Top
Posted by David Haley   USA  (3,881 posts)  Bio
Date Reply #1 on Thu 06 Dec 2007 10:33 PM (UTC)
Message
What kind of errors are you getting? One of the most common ones is that 'class' is a keyword in C++ so you can't have fields called 'class'. I don't remember the process as being that hard, just a large number of details to take care of.
David Haley aka Ksilyan
Head Programmer,
Legends of the Darkstone

http://david.the-haleys.org
Top
Posted by Gohan_TheDragonball   USA  (183 posts)  Bio
Date Reply #2 on Fri 07 Dec 2007 01:20 PM (UTC)
Message
out of this world prog system?? tell us more
Top
Posted by Samson   USA  (683 posts)  Bio
Date Reply #3 on Fri 07 Dec 2007 02:08 PM (UTC)
Message
The best way to approach it is one small chunk at a time. Don't let the volume of errors and warnings get to you.

If your Makefile has extra flags to trigger more warnings than usual, you might want to try disabling some of those at first. It'll make weeding out the real problems a little easier. It might also be helpful to add -Werror so that you only get one file's worth of information at a time. It makes things a bit more manageable that way.

There's also a script that was posted to this forum somewhere that will do the dirty work of making ->class into ->Class so that the compiler will quit complaining about the member name. You'll get the same from a few places that use ->new as a member name.

And of course, we're all curious about this new mudprog code you've mentioned :)
Top
Posted by Robert Powell   Australia  (367 posts)  Bio
Date Reply #4 on Sun 09 Dec 2007 06:29 AM (UTC)
Message
i did a bit of searching for this script, does anyone have an actual link to it, because i cannot find it.
Just a guy having a bit of fun. Nothing more, nothing less, I do not need I WIN to feel validated.
Top
Posted by Nick Gammon   Australia  (23,140 posts)  Bio   Forum Administrator
Date Reply #5 on Sun 09 Dec 2007 07:12 PM (UTC)
Message
Something like this should do it:


 perl -pi -e 's/class/Class/g' *.c

- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top
Posted by Robert Powell   Australia  (367 posts)  Bio
Date Reply #6 on Mon 10 Dec 2007 01:52 AM (UTC)
Message
Ok, now we go onto the next step of actually fixing the bits of code that G++ has a time dealing with.


g++ -c -g2 -Wall -Wshadow -Wformat-security -Winline -Wpointer-arith -Wcast-align -Wredundant-decls -export-dynamic act_obj.c
act_obj.c: In function ‘void do_rolldie(CHAR_DATA*, char*)’:
act_obj.c:3406: error: invalid conversion from ‘void*’ to ‘bool*’
act_obj.c: In function ‘char* get_chance_verb(OBJ_DATA*)’:
act_obj.c:3489: error: invalid conversion from ‘const char*’ to ‘char*’
gmake: *** [act_obj.o] Error 1
*** Exited with status: 2 ***


and the block of code,


char *get_chance_verb( OBJ_DATA * obj )
{
   return ( obj->action_desc[0] != '\0' ) ? obj->action_desc : "roll$q";
}


From the look of it most of my errors are just like this one, invalid conversions, but i have no idea what it means and even less of an idea on how to fix it. Thanks for your help.
Just a guy having a bit of fun. Nothing more, nothing less, I do not need I WIN to feel validated.
Top
Posted by David Haley   USA  (3,881 posts)  Bio
Date Reply #7 on Mon 10 Dec 2007 04:20 AM (UTC)
Message
The nasty fix is to cast the below to char* before returning it. The proper fix is to change the function's return type to const char* and adjusting code that calls it wherever necessary.

There was a thread on the FUSS forums about why it's such a problem to do the "nasty fix", but unfortunately it was lost during a drive crash. The short version is that the string literal "roll$q" is in the data segment of the program and most operating systems will prevent you from writing to it. But if you treat it as a char*, the compiler will cheerfully let you modify it, which will produce crashes.
David Haley aka Ksilyan
Head Programmer,
Legends of the Darkstone

http://david.the-haleys.org
Top
Posted by Robert Powell   Australia  (367 posts)  Bio
Date Reply #8 on Mon 10 Dec 2007 11:12 PM (UTC)
Message
Ok, i have gotten to the point where every file compiles all be it with a bunch of warnings about signed and unsigned ints that i will fix later.

My main problem now is when it goes to link everything together is spits out a multitude of errors about multiple definitions.

Most of them seem to do with things that use LINK and UNLINK


ObjectFiles/act_info.o: In function `str_similarity(char const*, char const*)':
/home/robert/eldhamud.v5/src/act_info.c:2289: multiple definition of `first_homebuy'
ObjectFiles/act_comm.o:/home/robert/eldhamud.v5/src/act_comm.c:2337: first defined here
ObjectFiles/act_info.o: In function `str_similarity(char const*, char const*)':
/home/robert/eldhamud.v5/src/act_info.c:2289: multiple definition of `last_homebuy'
ObjectFiles/act_comm.o:/home/robert/eldhamud.v5/src/act_comm.c:2337: first defined here
ObjectFiles/act_info.o: In function `str_similarity(char const*, char const*)':
/home/robert/eldhamud.v5/src/act_info.c:2291: multiple definition of `first_lmsg'
ObjectFiles/act_comm.o:/home/robert/eldhamud.v5/src/act_comm.c:2341: first defined here
ObjectFiles/act_info.o: In function `str_similarity(char const*, char const*)':
/home/robert/eldhamud.v5/src/act_info.c:2293: multiple definition of `last_lmsg'
ObjectFiles/act_comm.o:/home/robert/eldhamud.v5/src/act_comm.c:2341: first defined here
ObjectFiles/act_info.o: In function `str_similarity(char const*, char const*)':
/home/robert/eldhamud.v5/src/act_info.c:2293: multiple definition of `first_home'
ObjectFiles/act_comm.o:/home/robert/eldhamud.v5/src/act_comm.c:2342: first defined here
ObjectFiles/act_info.o: In function `str_similarity(char const*, char const*)':
/home/robert/eldhamud.v5/src/act_info.c:2293: multiple definition of `last_home'
ObjectFiles/act_comm.o:/home/robert/eldhamud.v5/src/act_comm.c:2342: first defined here
ObjectFiles/act_info.o: In function `str_similarity(char const*, char const*)':
/home/robert/eldhamud.v5/src/act_info.c:2293: multiple definition of `first_accessory'
ObjectFiles/act_comm.o:/home/robert/eldhamud.v5/src/act_comm.c:2343: first defined here
ObjectFiles/act_info.o: In function `str_similarity(char const*, char const*)':
/home/robert/eldhamud.v5/src/act_info.c:2294: multiple definition of `last_accessory'
ObjectFiles/act_comm.o:/home/robert/eldhamud.v5/src/act_comm.c:2343: first defined here
ObjectFiles/act_info.o: In function `str_similarity(char const*, char const*)':
/home/robert/eldhamud.v5/src/act_info.c:2294: multiple definition of `DONT_UPPER'
ObjectFiles/act_comm.o:/home/robert/eldhamud.v5/src/act_comm.c:2341: first defined here
ObjectFiles/act_info.o: In function `str_similarity(char const*, char const*)':
/home/robert/eldhamud.v5/src/act_info.c:2294: multiple definition of `area_version'
ObjectFiles/act_comm.o:/home/robert/eldhamud.v5/src/act_comm.c:2341: first defined here
ObjectFiles/act_info.o: In function `str_similarity(char const*, char const*)':
/home/robert/eldhamud.v5/src/act_info.c:2298: multiple definition of `MOBtrigger'
ObjectFiles/act_comm.o:/home/robert/eldhamud.v5/src/act_comm.c:2341: first defined here
ObjectFiles/act_info.o: In function `str_similarity(char const*, char const*)':


I tryed doing this to each of my headers so they only get defined one time, but even that didnt seem to do anything, i just got the same mass of linking errors.


#if !defined(_INC_HOUSE_H_) 
#define _INC_HOUSE_H_
^
codeblock
^
#endif //_INC_HOUSE_H_


Thanks in advance for any idead to whats going on here.
Just a guy having a bit of fun. Nothing more, nothing less, I do not need I WIN to feel validated.
Top
Posted by David Haley   USA  (3,881 posts)  Bio
Date Reply #9 on Tue 11 Dec 2007 12:13 AM (UTC)
Message
Let's start with the first error. What exactly is: first_homebuy and what do the two definitions look like? e.g. show those two lines of code.

One thing is that you might need to do the ol' make-clean and remake...
David Haley aka Ksilyan
Head Programmer,
Legends of the Darkstone

http://david.the-haleys.org
Top
Posted by Robert Powell   Australia  (367 posts)  Bio
Date Reply #10 on Tue 11 Dec 2007 12:54 AM (UTC)

Amended on Tue 11 Dec 2007 12:58 AM (UTC) by Robert Powell

Message
First one,

/home/robert/eldhamud.v5/src/act_info.c:2289: multiple definition of `first_homebuy'


>>> short str_similarity ( const char *astr, const char *bstr )
{
	short matches = 0;

	if ( !astr || !bstr )
		return matches;

	for ( ; *astr; astr++ )
	{
		if ( LOWER ( *astr ) == LOWER ( *bstr ) )
			matches++;

		if ( ++bstr == '\0' )
			return matches;
	}

	return matches;
}


2nd one

ObjectFiles/act_comm.o:/home/robert/eldhamud.v5/src/act_comm.c:2337: first defined here


>>>bool circle_follow( CHAR_DATA * ch, CHAR_DATA * victim )
{
   CHAR_DATA *tmp;

   for( tmp = victim; tmp; tmp = tmp->master )
      if( tmp == ch )
         return TRUE;
   return FALSE;
}


From house.h

HOMEBUY_DATA *first_homebuy;
HOMEBUY_DATA *last_homebuy;

I dont know what more to add, other than it has confused the heck out of me. Oh and i had make cleaned it each time i compiled.
Just a guy having a bit of fun. Nothing more, nothing less, I do not need I WIN to feel validated.
Top
Posted by David Haley   USA  (3,881 posts)  Bio
Date Reply #11 on Tue 11 Dec 2007 01:59 AM (UTC)
Message
Umm... hrm. That's not making any sense at all. :-)

Is there a place you could put the source files for me to download? If you don't mind I'd like to try compiling them myself...
David Haley aka Ksilyan
Head Programmer,
Legends of the Darkstone

http://david.the-haleys.org
Top
Posted by Robert Powell   Australia  (367 posts)  Bio
Date Reply #12 on Tue 11 Dec 2007 03:14 AM (UTC)
Message
Not at all, i just emailed it to you at your at-the-haleys.org address.
Just a guy having a bit of fun. Nothing more, nothing less, I do not need I WIN to feel validated.
Top
Posted by Samson   USA  (683 posts)  Bio
Date Reply #13 on Tue 11 Dec 2007 05:04 AM (UTC)
Message 
From house.h

HOMEBUY_DATA *first_homebuy;
HOMEBUY_DATA *last_homebuy;


In the .h file those should have "extern" in front, without the quotes. Then somewhere in the source code for the housing system, put the declarations in, without the extern.
Top
Posted by Robert Powell   Australia  (367 posts)  Bio
Date Reply #14 on Tue 11 Dec 2007 06:12 AM (UTC)
Message
Thanks samson, that is exactly what was happening, but could you explain to me why it was happening so i can understand things a bit better.
Just a guy having a bit of fun. Nothing more, nothing less, I do not need I WIN to feel validated.
Top

The dates and times for posts above are shown in Universal Co-ordinated Time (UTC).

To show them in your local time you can join the forum, and then set the 'time correction' field in your profile to the number of hours difference between your location and UTC time.

51,447 views.

This is page 1, subject is 2 pages long: 1 2  [Next page]

It is now over 60 days since the last post. This thread is closed.     Refresh page

Go to topic:           Search the forum

[Go to top] top

Information and images on this site are licensed under the Creative Commons Attribution 3.0 Australia License unless stated otherwise.

Home