Register forum user name Search FAQ

Gammon Forum

Notice: Any messages purporting to come from this site telling you that your password has expired, or that you need to verify your details, confirm your email, resolve issues, making threats, or asking for money, are spam. We do not email users with any such messages. If you have lost your password you can obtain a new one by using the password reset link.

Due to spam on this forum, all posts now need moderator approval.

 Entire forum ➜ MUSHclient ➜ Bug reports ➜ calling TextRectangle doesn't update the auto-wrap column

calling TextRectangle doesn't update the auto-wrap column

It is now over 60 days since the last post. This thread is closed.     Refresh page


Posted by Fiendish   USA  (2,551 posts)  Bio   Global Moderator
Date Sun 28 Nov 2010 08:47 PM (UTC)
Message
With "Auto-wrap to window size" enabled, if I call TextRectangle to change the size of the output region, new text still wraps at the old location. The wrap column doesn't change unless I resize the program window. Changing the size of the whole program by, let's say 1 pixel, will then cause new text to start wrapping at the edge of the textrectangle.

The wrap column should get updated by calls to TextRectangle if auto-wrap to window size is enabled.

https://github.com/fiendish/aardwolfclientpackage
Top

Posted by Fiendish   USA  (2,551 posts)  Bio   Global Moderator
Date Reply #1 on Sun 28 Nov 2010 08:49 PM (UTC)
Message
Also, the "Adjust width to size" button should use the smaller of TextRectangle width and window width. Currently it just uses window width.

https://github.com/fiendish/aardwolfclientpackage
Top

Posted by Nick Gammon   Australia  (23,169 posts)  Bio   Forum Administrator
Date Reply #2 on Sun 28 Nov 2010 11:09 PM (UTC)
Message
Fixed in version 4.71.

- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top

Posted by Fiendish   USA  (2,551 posts)  Bio   Global Moderator
Date Reply #3 on Sun 28 Nov 2010 11:15 PM (UTC)
Message
Awesome. Also, it looks like the wrap column only gets updated while the world is connected. Bug?

https://github.com/fiendish/aardwolfclientpackage
Top

Posted by Nick Gammon   Australia  (23,169 posts)  Bio   Forum Administrator
Date Reply #4 on Sun 28 Nov 2010 11:26 PM (UTC)
Message
It looks like by design, not sure why ...


// don't resize if not active, or minimized, or closed
if (wp.showCmd != SW_MINIMIZE &&
    pDoc->m_iConnectPhase == eConnectConnectedToMud &&
    (
    pDoc->m_pActiveOutputView == this  ||
    pDoc->m_pActiveCommandView == m_bottomview
    ))
    AutoWrapWindowWidth (pDoc);


- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top

Posted by Nick Gammon   Australia  (23,169 posts)  Bio   Forum Administrator
Date Reply #5 on Sun 28 Nov 2010 11:28 PM (UTC)
Message
Probably because of this:

http://www.gammon.com.au/scripts/showrelnote.php?version=3.74&productid=0

Point 4.

- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top

Posted by Nick Gammon   Australia  (23,169 posts)  Bio   Forum Administrator
Date Reply #6 on Sun 28 Nov 2010 11:30 PM (UTC)
Message
Or more likely, this:

http://www.gammon.com.au/scripts/showrelnote.php?version=3.35&productid=0

Point 4.

- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top

Posted by Fiendish   USA  (2,551 posts)  Bio   Global Moderator
Date Reply #7 on Sun 28 Nov 2010 11:51 PM (UTC)
Message
Odd. If it stays that way, I'd update wrap columns on connect. Otherwise textrects that get sized before connection will mysteriously not adjust wrapping.

https://github.com/fiendish/aardwolfclientpackage
Top

Posted by Fiendish   USA  (2,551 posts)  Bio   Global Moderator
Date Reply #8 on Sun 28 Nov 2010 11:54 PM (UTC)

Amended on Sun 28 Nov 2010 11:55 PM (UTC) by Fiendish

Message
Though, actually, neither of those issues has to do with mud connection. Only being backgrounded, not disconnected. So maybe remove the check for m_iConnectPhase? Updating on connect might be safer, though, given that there might be a good reason for the check that just isn't immediately obvious.

https://github.com/fiendish/aardwolfclientpackage
Top

Posted by Nick Gammon   Australia  (23,169 posts)  Bio   Forum Administrator
Date Reply #9 on Mon 29 Nov 2010 12:13 AM (UTC)
Message
I'm inclined to agree it shouldn't matter. I've taken it out and we'll see what happens.

- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top

The dates and times for posts above are shown in Universal Co-ordinated Time (UTC).

To show them in your local time you can join the forum, and then set the 'time correction' field in your profile to the number of hours difference between your location and UTC time.


24,938 views.

It is now over 60 days since the last post. This thread is closed.     Refresh page

Go to topic:           Search the forum


[Go to top] top

Information and images on this site are licensed under the Creative Commons Attribution 3.0 Australia License unless stated otherwise.