Register forum user name Search FAQ

Gammon Forum

Notice: Any messages purporting to come from this site telling you that your password has expired, or that you need to verify your details, confirm your email, resolve issues, making threats, or asking for money, are spam. We do not email users with any such messages. If you have lost your password you can obtain a new one by using the password reset link.

Due to spam on this forum, all posts now need moderator approval.

 Entire forum ➜ MUSHclient ➜ Bug reports ➜ Race during startup posts incorrect window width/height?

Race during startup posts incorrect window width/height?

It is now over 60 days since the last post. This thread is closed.     Refresh page


Posted by Fiendish   USA  (2,551 posts)  Bio   Global Moderator
Date Mon 25 Feb 2013 07:10 PM (UTC)
Message
In the moments during client start up, calls to GetInfo(280) and GetInfo(281) can apparently report the wrong numbers. I say wrong here because it looks like maybe the client window zooms to size but hasn't gotten to the desired size yet?

A user reported the following to me.

Quote:
when I start mush, the GetInfo(281) is returning a (incorrect?) value of 645.

If I reinstall the plugin, GetInfo(281) returns a more realistic value.

Debug Data on initial load
~~~~~~~~~~~~~~~~~~~~~~~~~~

GetInfo(281) = 645

Debug Data on plugin reinstall
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

GetInfo(281) = 1303


I have noticed this myself in the past as well, but didn't think to report it as a problem for some reason.

https://github.com/fiendish/aardwolfclientpackage
Top

Posted by Nick Gammon   Australia  (23,166 posts)  Bio   Forum Administrator
Date Reply #1 on Tue 26 Feb 2013 12:47 AM (UTC)
Message
There are some race conditions there. Especially during initial startup the windows can be set to some default size (eg. chosen by the MFC library) before the code in MUSHclient has had a chance to read the saved window positions for that world and fix things up.

- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top

Posted by Nick Gammon   Australia  (23,166 posts)  Bio   Forum Administrator
Date Reply #2 on Tue 26 Feb 2013 12:59 AM (UTC)
Message
In particular, plugins are installed, and OnPluginInstall called, before the output window is set up.

I would suggest a short delay after the plugin starts up, if you need to know the output window size, that would give it a chance to stabilize.

- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top

Posted by Fiendish   USA  (2,551 posts)  Bio   Global Moderator
Date Reply #3 on Tue 26 Feb 2013 02:13 AM (UTC)

Amended on Tue 26 Feb 2013 02:16 AM (UTC) by Fiendish

Message
Quote:
In particular, plugins are installed, and OnPluginInstall called, before the output window is set up.

Is this avoidable? It's not intuitive and will randomly screw up anyone who tries to get window geometry at plugin load.

https://github.com/fiendish/aardwolfclientpackage
Top

Posted by Nick Gammon   Australia  (23,166 posts)  Bio   Forum Administrator
Date Reply #4 on Tue 26 Feb 2013 04:17 AM (UTC)
Message
See this post perhaps:

Template:post=11226 Please see the forum thread: http://gammon.com.au/forum/?id=11226.



:P

- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top

Posted by Nick Gammon   Australia  (23,166 posts)  Bio   Forum Administrator
Date Reply #5 on Tue 26 Feb 2013 04:18 AM (UTC)
Message
Fiendish said:

Is this avoidable?


I can't think of any particularly easy way, except maybe to defer loading plugins until somewhat later in the world-opening process.

- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top

Posted by Nick Gammon   Australia  (23,166 posts)  Bio   Forum Administrator
Date Reply #6 on Tue 26 Feb 2013 04:26 AM (UTC)
Message
Plugin loading is done as part of world (input) serialization, which is a part of opening a document. Basically we have all the XML data in memory, and are working through the various types of data (triggers, aliases etc.)

I'm not quite sure of the ramifications of attempting to defer the plugin part.

- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top

Posted by Fiendish   USA  (2,551 posts)  Bio   Global Moderator
Date Reply #7 on Tue 26 Feb 2013 01:46 PM (UTC)

Amended on Tue 26 Feb 2013 01:47 PM (UTC) by Fiendish

Message
Nick Gammon said:

See this post perhaps:

(post=11226)

:P


See? Randomly even to people who knew about it 2 years ago.

https://github.com/fiendish/aardwolfclientpackage
Top

The dates and times for posts above are shown in Universal Co-ordinated Time (UTC).

To show them in your local time you can join the forum, and then set the 'time correction' field in your profile to the number of hours difference between your location and UTC time.


22,330 views.

It is now over 60 days since the last post. This thread is closed.     Refresh page

Go to topic:           Search the forum


[Go to top] top

Information and images on this site are licensed under the Creative Commons Attribution 3.0 Australia License unless stated otherwise.