Search FAQ

Gammon Forum

Notice: Any messages purporting to come from this site telling you that your password has expired, or that you need to verify your details, confirm your email, resolve issues, making threats, or asking for money, are spam. We do not email users with any such messages. If you have lost your password you can obtain a new one by using the password reset link.
 Entire forum ➜ SMAUG ➜ SMAUG coding ➜ Segment fault in Comm.c (Smaug 1.4a)
Segment fault in Comm.c (Smaug 1.4a)

Posting of new messages is disabled at present.

Refresh page

Pages: 1 2  

Posted by Syriac   (46 posts)  Bio
Date Sun 07 Jun 2009 03:42 PM (UTC)
Message
I'm having an issue in my MUD where players sometimes will inadvertantly crash us by killing a mob. It is random, and it takes time for it to happen but it seems to happen without fail eventually.

I booted up the mud in GDB and got this feedback.

Program received signal SIGSEGV, Segmentation fault.
0x000000000045e4c5 in act (AType=1045,
format=0x20000000d <Address 0x20000000d out of bounds>, ch=0xd63e50,
arg1=0x0, arg2=0x0, type=0) at comm.c:3167
3167 if ( !format || format[0] == '\0' )

has this happened to anyone else? how was it resolved? help please!
Top
Posted by Conner   USA  (381 posts)  Bio
Date Reply #1 on Sun 07 Jun 2009 07:03 PM (UTC)
Message
I didn't find anything about this particular one at www.smaugmuds.org, but it'd probably be a pretty good place to look, even if you're not using SmaugFUSS (though I'd have to say that you'd have far less trouble, in general, if you were, but I also understand that sometimes it's not practical to change codebases that way). I can't say that I've seen this particular one myself before but perhaps if you could give us a little more info? Maybe show us a few lines of the code in your comm.c before and after that one?
-=Conner=-
--
Come test your mettle in the Land of Legends at telnet://tcdbbs.zapto.org:4000
or, for a little family oriented medieval fun, come join us at The Castle's Dungeon BBS at telnet://tcdbbs.zapto.org
or, if you just want information about either, check our web page at http://tcdbbs.zapto.org
Top
Posted by Syriac   (46 posts)  Bio
Date Reply #2 on Sun 07 Jun 2009 08:57 PM (UTC)
Message
void act( sh_int AType, const char *format, CHAR_DATA *ch, const void
*arg1, const void *arg2, int type )
{
char *txt;
const char *str;
CHAR_DATA *to;
CHAR_DATA *vch = (CHAR_DATA *)arg2;
#define ACTF_NONE 0
#define ACTF_TXT BV00
#define ACTF_CH BV01
#define ACTF_OBJ BV02

OBJ_DATA *obj1 = (OBJ_DATA *)arg1;
OBJ_DATA *obj2 = (OBJ_DATA *)arg2;
int flags1 = ACTF_NONE, flags2 = ACTF_NONE;

/*
* Discard null and zero-length messages.
*/
if ( !format || format[0] == '\0' )
return;

if ( !ch )
{
bug( "Act: null ch. (%s)", format );
return;
}

// Do some proper type checking here.. Sort of. We base it on the $* params.
// This is kinda lame really, but I suppose in some weird sense it beats having
// to pass like 8 different NULL parameters every time we need to call act()..
for (str = format; *str; ++str)
{
if (*str == '$')
{
if (!*++str)
break;
switch(*str)
{
default:
bug( "Act: bad code %c for format %s.", *str, format );
break;

case 't':
flags1 |= ACTF_TXT;
obj1 = NULL;
break;

case 'T':
case 'd':
flags2 |= ACTF_TXT;
vch = NULL;
obj2 = NULL;
break;

case 'n': case 'e': case 'm': case 's': case 'q':
break;

case 'N': case 'E': case 'M': case 'S': case 'Q':
flags2 |= ACTF_CH;
obj2 = NULL;
break;

case 'p':
flags1 |= ACTF_OBJ;
break;

case 'P':
flags2 |= ACTF_OBJ;
vch = NULL;
break;
}
}
}


if (flags1 != ACTF_NONE && flags1 != ACTF_TXT && flags1 != ACTF_CH && flags1 != ACTF_OBJ)
{
bug("Act: arg1 has more than one type in format %s. Setting all NULL.", format);
obj1 = NULL;
}

if (flags2 != ACTF_NONE && flags2 != ACTF_TXT && flags2 != ACTF_CH && flags2 != ACTF_OBJ)
{
bug("Act: arg2 has more than one type in format %s. Setting all NULL.", format);
vch = NULL;
obj2 = NULL;
}

if ( !ch->in_room )
to = NULL;
else if ( type == TO_CHAR )
to = ch;
else
to = ch->in_room->first_person;

/*
* ACT_SECRETIVE handling
*/
if ( IS_NPC(ch) && xIS_SET(ch->act, ACT_SECRETIVE) && type != TO_CHAR )
return;

if ( type == TO_VICT )
{
if ( !vch )
{
bug( "Act: null vch with TO_VICT." );
bug( "%s (%s)", ch->name, format );
return;
}
if ( !vch->in_room )
{
bug( "Act: vch in NULL room!" );
bug( "%s -> %s (%s)", ch->name, vch->name, format );
return;
}
to = vch;
/* to = vch->in_room->first_person;*/
}

if ( MOBtrigger && type != TO_CHAR && type != TO_VICT && to )
{
OBJ_DATA *to_obj;

txt = act_string(format, NULL, ch, arg1, arg2, STRING_IMM);
if ( HAS_PROG(to->in_room, ACT_PROG) )
rprog_act_trigger(txt, to->in_room, ch, (OBJ_DATA *)arg1, (void *)arg2);
for ( to_obj = to->in_room->first_content; to_obj;
to_obj = to_obj->next_content )
if ( HAS_PROG(to_obj->pIndexData, ACT_PROG) )
oprog_act_trigger(txt, to_obj, ch, (OBJ_DATA *)arg1, (void *)arg2);
}

/* Anyone feel like telling me the point of looping through the whole
room when we're only sending to one char anyways..? -- Alty */
for ( ; to; to = (type == TO_CHAR || type == TO_VICT)
? NULL : to->next_in_room )
{
if ((!to->desc
&& ( IS_NPC(to) && !HAS_PROG(to->pIndexData, ACT_PROG) ))
|| !IS_AWAKE(to) )
continue;

if ( type == TO_CHAR && to != ch )
continue;
if ( type == TO_VICT && ( to != vch || to == ch ) )
continue;
if ( type == TO_ROOM && to == ch )
continue;
if ( type == TO_NOTVICT && (to == ch || to == vch) )
continue;
if ( type == TO_CANSEE && ( to == ch ||
(!IS_NPC(ch) && (xIS_SET(ch->act, PLR_WIZINVIS)
&& (get_trust(to) < (ch->pcdata ? ch->pcdata->wizinvis : 0) ) ) ) ) )
continue;

if ( IS_IMMORTAL(to) )
txt = act_string (format, to, ch, arg1, arg2, STRING_IMM);
else
txt = act_string (format, to, ch, arg1, arg2, STRING_NONE);

if (to->desc)
{
if ( AType == AT_COLORIZE )
{
if ( txt[0] == '&' )
send_to_char_color( txt, to );
else
{
set_char_color(AT_MAGIC, to );
write_to_buffer( to->desc, txt, strlen(txt) );
}
}
else {
set_char_color(AType, to);
write_to_buffer( to->desc, txt, strlen(txt) );
}
}
if (MOBtrigger)
{
/* Note: use original string, not string with ANSI. -- Alty */
mprog_act_trigger( txt, to, ch, (OBJ_DATA *)arg1, (void *)arg2 );
}
}
MOBtrigger = TRUE;
return;
}
Top
Posted by Nick Gammon   Australia  (23,122 posts)  Bio   Forum Administrator
Date Reply #3 on Sun 07 Jun 2009 09:57 PM (UTC)

Amended on Sun 07 Jun 2009 09:59 PM (UTC) by Nick Gammon

Message
Quote:

... i couldn't see a delete option. ...


If you log into the forum (in the top RH corner of this message) you can delete your own messages.


Program received signal SIGSEGV, Segmentation fault.
0x000000000045e4c5 in act (AType=1045,
format=0x20000000d <Address 0x20000000d out of bounds>, ch=0xd63e50,
arg1=0x0, arg2=0x0, type=0) at comm.c:3167
3167 if ( !format || format[0] == '\0' )


You can do a backtrace by typing "bt" in gdb once you see this message. See my posting at http://mushclient.com/gdb for using gdb.

Judging by what little I see here, in comm.c at line 3167, it is accessing the pointer "format" which is not nil, however its value looks invalid to me (0x20000000d) which probably means it is corrupted. For example 20 is a space and 0d is a carriage-return.

Since the function you posted has not changed format at that point, it has been corrupted earlier, which is why you need to see the backtrace. However memory corruption can be a funny thing, the real culprit might have happened a few minutes earlier.

If possible I would upgrade to SmaugFUSS, Smaug 1.4a has lots of known bugs, which is why SmaugFUSS (fixed up smaug source) was released.

Failing that, possibly you might detect it with a hardware watch point, which detects when variables change. If the variable (format) always changes to 0x20000000d and not some random value, then watching it for that particular value might show the exact moment it gets corrupted (look for "watch" in my gdb posting).
- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top
Posted by Nick Gammon   Australia  (23,122 posts)  Bio   Forum Administrator
Date Reply #4 on Sun 07 Jun 2009 10:06 PM (UTC)
Message
Also read the gdb post for conditional breakpoints. Maybe one of those would detect the corruption of format before it got too far away to see why it happened.
- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top
Posted by Syriac   (46 posts)  Bio
Date Reply #5 on Mon 08 Jun 2009 02:06 AM (UTC)
Message
(gdb) bt
#0 0x000000000045e563 in act (AType=1045, format=0x20000000d <Address 0x20000000d out of bounds>, ch=0xe451c0, arg1=0x0, arg2=0x0, type=0)
at comm.c:3178
#1 0x000000000047732f in death_cry (ch=0xe451c0) at fight.c:6387
#2 0x00000000004b5c1a in mprog_death_trigger (killer=<value optimized out>, mob=0xe451c0) at mud_prog.c:2435
#3 0x0000000000477ab5 in raw_kill (ch=0xf85da0, victim=0xe451c0) at fight.c:6544
#4 0x000000000047be68 in damage (ch=0xf85da0, victim=0xe451c0, dam=1344, dt=1006) at fight.c:4674
#5 0x000000000047d47a in one_hit (ch=0xf85da0, victim=0xe451c0, dt=1006) at fight.c:2576
#6 0x00000000004d4c56 in do_hitall (ch=0xf85da0, argument=<value optimized out>) at skills.c:8109
#7 0x00000000004de6bf in check_skill (ch=0xf85da0, command=<value optimized out>, argument=0x7fffffffe196 "") at skills.c:795
#8 0x000000000048fc19 in interpret (ch=0xf85da0, argument=0x7fffffffe196 "") at interp.c:660
#9 0x0000000000463017 in game_loop () at comm.c:684
#10 0x0000000000463847 in main (argc=<value optimized out>, argv=0x7fffffffe758) at comm.c:331
(gdb)



I'm thinking it is in the death cry since or death triggers since it happens when something is about to die... I've googled up, this doesn't seem to be a common smaug error. As far as switching bases - not really likely... I've been working on this code for 4 years... this has just always been something we've sort of dealt with. It really needs to get fixed... blahhhh. This is confusing
Top
Posted by Zeno   USA  (2,871 posts)  Bio
Date Reply #6 on Mon 08 Jun 2009 02:17 AM (UTC)
Message
You need to adjust your Makefile so you don't get stuff like value optimized out.
Zeno McDohl,
Owner of Bleached InuYasha Galaxy
http://www.biyg.org
Top
Posted by Syriac   (46 posts)  Bio
Date Reply #7 on Mon 08 Jun 2009 02:38 AM (UTC)
Message
I took the -O out of my Makefile... its still doing this... :-/
Top
Posted by Zeno   USA  (2,871 posts)  Bio
Date Reply #8 on Mon 08 Jun 2009 02:48 AM (UTC)
Message
Did you make sure to clean compile?
Zeno McDohl,
Owner of Bleached InuYasha Galaxy
http://www.biyg.org
Top
Posted by Nick Gammon   Australia  (23,122 posts)  Bio   Forum Administrator
Date Reply #9 on Mon 08 Jun 2009 02:54 AM (UTC)
Message
Make sure you rm *.o (or make clean) to get each file compiled without the optimization.

You seem to be calling act from the function death_cry at fight.c line 6387 with an invalid value for format. Can you show the lines around that spot in fight.c - especially where it establishes a value for format?
- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top
Posted by Nick Gammon   Australia  (23,122 posts)  Bio   Forum Administrator
Date Reply #10 on Mon 08 Jun 2009 02:56 AM (UTC)
Message
I would also be printing the value for the mob in question (ie. type "f 2" to go up to that frame, and then "p *mob").

Maybe the death cry is too long for some buffer you have?
- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top
Posted by Syriac   (46 posts)  Bio
Date Reply #11 on Mon 08 Jun 2009 03:04 AM (UTC)
Message
That makes sense... Since it seems random, could be a longer death cry crashing it -- I did do a make clean... the lines it is calling to are as follows---

was_in_room = ch->in_room;
for ( pexit = was_in_room->first_exit; pexit; pexit = pexit->next )
{
if ( pexit->to_room && pexit->to_room != was_in_room )
{
ch->in_room = pexit->to_room;
act( AT_CARNAGE, msg, ch, NULL, NULL, TO_ROOM );
}
}
ch->in_room = was_in_room;


I'm going to look into the buffer thing now - thanks for the continued help guys I appreciate it a lot! This has been giving me a headache all day!
Top
Posted by Zeno   USA  (2,871 posts)  Bio
Date Reply #12 on Mon 08 Jun 2009 03:07 AM (UTC)
Message
And you're debugging this after the clean compile, right? With a rebooted MUD?
Zeno McDohl,
Owner of Bleached InuYasha Galaxy
http://www.biyg.org
Top
Posted by Syriac   (46 posts)  Bio
Date Reply #13 on Mon 08 Jun 2009 03:09 AM (UTC)
Message
(gdb) f 2
#2 0x00000000004fd5cd in mprog_death_trigger (killer=0xff7bb0, mob=0xeb9bd0) at mud_prog.c:2435
2435 death_cry( mob );
(gdb) p *mob
$1 = {next = 0xeba1f0, prev = 0xeb87b0, next_in_room = 0xff7bb0, prev_in_room = 0x0, master = 0x0, leader = 0x0, fighting = 0x0, lord = 0x0, reply = 0x0, retell = 0x0,
switched = 0x0, mount = 0x0, hunting = 0x0, fearing = 0x0, hating = 0xdd2010, spec_fun = 0, mpact = 0x0, mpactnum = 0, mpscriptpos = 0, pIndexData = 0xb74e30, desc = 0x0,
first_affect = 0x0, last_affect = 0x0, pnote = 0x0, comments = 0x0, first_carrying = 0xeb9ec0, last_carrying = 0xeba0e0, in_room = 0xb7df40, was_in_room = 0xb7df40,
pcdata = 0x0, last_cmd = 0x404fe0 <do_say>, prev_cmd = 0, dest_buf = 0x0, alloc_ptr = 0x0, spare_ptr = 0x0, tempnum = 0, editor = 0x0, first_timer = 0x0, last_timer = 0x0,
morph = 0x0, name = 0xb74f50 "Queen Zizor", short_descr = 0xb74f50 "Queen Zizor", long_descr = 0xb74f80 "Queen Zizor is here on her throne.\n\r",
description = 0xb74fc0 "She looks very busy now, something must be going on.\n\r", num_fighting = 1, substate = 0, sex = 2, class = 25, dualclass = 0, oldclass = 0,
oldexp = 0, tierexp = 0, oldhit = 0, oldlevel = 0, oldmana = 0, oldmove = 0, mclass = 0, mclasslvl = 0, mclassexp = 0, race = 48, level = 55, trust = 0, played = 0,
logon = 1244430376, save_time = 0, birth_time = 0, timer = 0, wait = 0, day = 0, month = 0, year = 0, hit = -485, max_hit = 1485, mana = 100, max_mana = 100, move = 100,
max_move = 100, practice = 0, numattacks = 2, gold = 51, exp = 100, act = {bits = {16781315, 0, 0, 0}}, affected_by = {bits = {0, 0, 0, 0}}, no_affected_by = {bits = {0, 0, 0,
0}}, carry_weight = 1, carry_number = 1, xflags = 68158994, no_immune = 0, no_resistant = 0, no_susceptible = 0, immune = 0, resistant = 0, susceptible = 4194303,
attacks = {bits = {0, 0, 0, 0}}, defenses = {bits = {0, 0, 0, 0}}, speaks = 1048575, speaking = 1, saving_poison_death = 0, saving_wand = 0, saving_para_petri = 0,
saving_breath = 0, saving_spell_staff = 0, alignment = 500, barenumdie = 5, baresizedie = 5, mobthac0 = 25, hitroll = 20, damroll = 20, hitplus = 0, damplus = 1, position = 0,
defposition = 8, style = 0, height = 76, weight = 240, armor = -298, wimpy = 0, deaf = 0, perm_str = 25, perm_int = 25, perm_wis = 25, perm_dex = 25, perm_con = 25,
perm_cha = 25, perm_lck = 25, mod_str = 0, mod_int = 0, mod_wis = 3, mod_dex = 0, mod_con = 0, mod_cha = 3, mod_lck = 0, mental_state = 0, emotional_state = 0, pagelen = 24,
inter_page = 0, inter_type = 0, inter_editing = 0x0, inter_editing_vnum = -1, inter_substate = 0, retran = 0, regoto = 0, questgiver = 0x0, questpoints = 0, nextquest = 0,
countdown = 0, questobj = 0, questmob = 0, mobmaster = 0, mobmastercomplete = 0, ticks = 0, nextmobm = 0, mobmcountdown = 0, flgs = 0, steal = 0, mobinvis = 0, train = 0,
home_vnum = 14516}





Yeah it definitely seems like its the death cry. Maybe I can try to just get rid of the different death cries and just go with one that works.
Top
Posted by Syriac   (46 posts)  Bio
Date Reply #14 on Mon 08 Jun 2009 03:21 AM (UTC)
Message
It was the body parts code - thanks for your help everyone! I just commented it all out, don't need it anyway :)
Top

The dates and times for posts above are shown in Universal Co-ordinated Time (UTC).

To show them in your local time you can join the forum, and then set the 'time correction' field in your profile to the number of hours difference between your location and UTC time.

58,032 views.

This is page 1, subject is 2 pages long: 1 2  [Next page]

Posting of new messages is disabled at present.

Refresh page

Go to topic:           Search the forum

[Go to top] top

Information and images on this site are licensed under the Creative Commons Attribution 3.0 Australia License unless stated otherwise.

Home