Notice: Any messages purporting to come from this site telling you that your password has expired, or that you need to verify your details, confirm your email, resolve issues, making threats, or asking for money, are
spam. We do not email users with any such messages. If you have lost your password you can obtain a new one by using the
password reset link.
Due to spam on this forum, all posts now need moderator approval.
Entire forum
➜ MUSHclient
➜ Bug reports
➜ Pre-release build v5.05-pre fails to receive text sometimes
Pre-release build v5.05-pre fails to receive text sometimes
|
It is now over 60 days since the last post. This thread is closed.
Refresh page
Pages: 1
2
Posted by
| Nick Gammon
Australia (23,133 posts) Bio
Forum Administrator |
Date
| Reply #15 on Thu 02 Feb 2017 11:35 PM (UTC) |
Message
| Looking more closely at the Wireshark packet, it does not agree with the packet debug. I think I have found a bug in the sending routine. Recompiling now. |
- Nick Gammon
www.gammon.com.au, www.mushclient.com | Top |
|
Posted by
| Nick Gammon
Australia (23,133 posts) Bio
Forum Administrator |
Date
| Reply #16 on Fri 03 Feb 2017 12:13 AM (UTC) Amended on Fri 03 Feb 2017 12:21 AM (UTC) by Nick Gammon
|
Message
| |
Posted by
| Nick Gammon
Australia (23,133 posts) Bio
Forum Administrator |
Date
| Reply #17 on Fri 03 Feb 2017 12:29 AM (UTC) |
Message
| Thanks for reporting this BTW. I think I've had a couple of similar reports in the past, where people would send something and it wouldn't be received.
I think the explanation is that once the 0x00 byte gets into the output buffer it effectively terminated the string, so matter what additional things you typed, they were appended after the 0x00, and thus ignored.
In this particular case, the 0x00 was part of the telnet negotiation for the terminal type.
In particular, this packet:
Sent packet: 8 (16 bytes) at Thursday, February 02, 2017, 3:07:56 PM
ÿú..mushclientÿð ff fa 18 00 6d 75 73 68 63 6c 69 65 6e 74 ff f0
Note the "00" there? It is obvious once you look at it. |
- Nick Gammon
www.gammon.com.au, www.mushclient.com | Top |
|
Posted by
| Worstje
Netherlands (899 posts) Bio
|
Date
| Reply #18 on Fri 03 Feb 2017 12:31 AM (UTC) |
Message
| Patch confirmed. Latest pre-release works as it ought to. :-)
My apologies for getting you guys to dig through such a pre-release specific bug! | Top |
|
Posted by
| Nick Gammon
Australia (23,133 posts) Bio
Forum Administrator |
Date
| Reply #19 on Fri 03 Feb 2017 12:31 AM (UTC) |
Message
| What threw me out a bit was the bug report "Pre-release build v5.05-pre fails to receive text sometimes" - actually that was a symptom of a missing send - had the username been sent, then the server would have responded with the greeting text.
Hence all the mucking around checking what the problem was with the sending routine.
The fact that the IAC NOP still arrived was a bit of a tip that data was in fact still being received. |
- Nick Gammon
www.gammon.com.au, www.mushclient.com | Top |
|
Posted by
| Nick Gammon
Australia (23,133 posts) Bio
Forum Administrator |
Date
| Reply #20 on Fri 03 Feb 2017 12:33 AM (UTC) |
Message
|
Worstje said:
My apologies for getting you guys to dig through such a pre-release specific bug!
Not at all. It was a genuine bug. Sometimes genuine bugs survive for a while because of idiosyncrasies of memory layout (for example, uninitialized memory). |
- Nick Gammon
www.gammon.com.au, www.mushclient.com | Top |
|
Posted by
| Worstje
Netherlands (899 posts) Bio
|
Date
| Reply #21 on Fri 03 Feb 2017 12:52 AM (UTC) |
Message
| Honestly, I had seen the IAC NOP before I submitted. (You learn to recognise an IAC code after you've implemented a few telnet parsers.)
I wasn't sure if that was sent by the game (I never saw a game send that one before!) or a side-effect from the bug somehow misinterpreting the wrong byte for its telnet state machine, but at the time I was tired and just getting the two packet debugs I did out was all the time I could spend on it.
The IAC NOP was the reason why I wrote 'text' when describing the bug; clearly not everything went lost and I had a feeling the difference was incoming text vs (sub)negotiation stuff. And if everything had gone lost, I figured there would be an outright connection reset at some point. :-)
Thanks very much for the sleuthing! | Top |
|
Posted by
| Nick Gammon
Australia (23,133 posts) Bio
Forum Administrator |
Date
| Reply #22 on Fri 03 Feb 2017 01:10 AM (UTC) |
Message
| I suspect they send that to keep the connection alive. |
- Nick Gammon
www.gammon.com.au, www.mushclient.com | Top |
|
The dates and times for posts above are shown in Universal Co-ordinated Time (UTC).
To show them in your local time you can join the forum, and then set the 'time correction' field in your profile to the number of hours difference between your location and UTC time.
64,609 views.
This is page 2, subject is 2 pages long:
1
2
It is now over 60 days since the last post. This thread is closed.
Refresh page
top