Gammon Forum : MUSHclient : Bug reports : Erroneus calls to OnPluginSelectionChanged

Entire forum ➜ MUSHclient ➜ Bug reports ➜ Erroneus calls to OnPluginSelectionChanged

Erroneus calls to OnPluginSelectionChanged

It is now over 60 days since the last post. This thread is closed. Refresh page

Posted by Fiendish USA (2,533 posts) Bio Global Moderator

Date

Wed 06 Jan 2021 06:16 PM (UTC)

Amended on Wed 06 Jan 2021 07:57 PM (UTC) by Fiendish

Message

In trying to debug https://mushclient.com/forum/?id=14801&page=999, I turned on tracing and noticed a bunch of erroneous calls to OnPluginSelectionChanged where GetSelectionStartLine(), GetSelectionEndLine(), GetSelectionStartColumn(), GetSelectionEndColumn() all return 0.

The traces always come in pairs and look like this:


...
| 44234|30 Jul 13:08| Fuel        | insane >t9 idea. but maybe it would |   7|
| 44235|30 Jul 13:17| Yakuza      | Re: insane >t9 idea. but maybe it w |   6|
| 44236|30 Jul 13:14| Veritheia   | Reduce time required to achieve Tie |  20|
| 44237|30 Jul 13:26| Macbeth     | Reduce time required to achieve Tie |  25|
| 44238|30 Jul 13:30| Raoh        | Reduce time required to achieve Tie |   7|
| 44239|30 Jul 13:34| Yakuza      | Reduce time required to achieve Tie |   4|
| 44240|30 Jul 13:35| Raoh        | Reduce time required to achieve Tie |  11|
| 44241|30 Jul 13:39| Castiel     | Reduce time required to achieve Tie |  13|
| 44242|30 Jul 13:38| Vyndalas    | Reduce time required to achieve Tie |  23|
TRACE: Executing Plugin Splitscreen_Scrollback script "OnPluginSelectionChanged"
TRACE: Executing Plugin Splitscreen_Scrollback script "OnPluginSelectionChanged"
| 44243|30 Jul 13:54| Rezit       | Reduce time required to achieve Tie |  37|
| 44244|30 Jul 13:55| Yakuza      | Reduce time required to achieve Tie |   7|
| 44245|30 Jul 14:20| Zhalut      | Reduce time required to achieve Tie |   7|
| 44246|30 Jul 14:22| Zhalut      | Reduce time required to achieve Tie |   7|
| 44247|30 Jul 14:24| Castiel     | Reduce time required to achieve Tie |  53|
| 44248|30 Jul 14:31| Vyndalas    | Reduce time required to achieve Tie |   5|
| 44249|30 Jul 14:38| Raoh        | Reduce time required to achieve Tie |  20|
| 44250|30 Jul 14:56| Thridi      | Reduce time required to achieve Tie |  14|
| 44251|30 Jul 15:23| Zafrusteria | Re: Reduce time required to achieve |  32|
| 44252|30 Jul 18:59| Throxx      | Re: Reduce time required to achieve |  24|
...

If I make OnPluginSelectionChanged print the selection metrics, I get something like:


...
| 44793|11 Oct 13:11| Xyzzy       | Re: Make ventriloquate useful? ++   |   3|
| 44794|11 Oct 13:16| Tial        | Command to search your inventory    |   4|
| 44795|11 Oct 13:40| Tymme       | spamreduce sharegold                |   3|
| 44796|11 Oct 16:04| Mannec      | Re: Command to search your inventor |   4|
| 44797|12 Oct 01:38| Zhalut      | auto keep options                   |   3|
| 44798|12 Oct 10:26| Guinness    | The Daily Double                    |  27|
| 44800|13 Oct 22:36| Tymme       | Enchantment result messages         |  13|
| 44802|14 Oct 18:38| Tymme       | setflag <options> confirm           |  17|
| 44803|14 Oct 23:07| Wars        | New GQ Win Brackets                 |  11|
selection values are: 0 0 0 0
| 44804|15 Oct 00:46| Brobeo      | Re: New GQ Win Brackets             |  11|
TRACE: Executing Plugin Splitscreen_Scrollback script "OnPluginSelectionChanged"
selection values are: 0 0 0 0
TRACE: Executing Plugin Splitscreen_Scrollback script "OnPluginSelectionChanged"
| 44805|15 Oct 10:47| Tymme       | Re: New GQ Win Brackets +           |  13|
| 44806|15 Oct 11:10| Guinness    | Re: New GQ Win Brackets ++          |   4|
| 44807|15 Oct 11:23| Mendaloth   | Re: New GQ Win Brackets +++         |  13|
| 44808|15 Oct 11:30| Tymme       | Re: New GQ Win Brackets ++++        |  14|
| 44809|15 Oct 13:21| Redryn      | Re: New GQ Win Brackets +++++       |   4|
| 44810|16 Oct 00:28| Macbeth     | global spellup lead time            |   6|
| 44811|16 Oct 00:30| Veritheia   | Re: global spellup lead time        |   3|
| 44812|16 Oct 00:35| Macbeth     | Re: global spellup lead time +      |   6|
| 44813|16 Oct 00:37| Macbeth     | Re: global spellup lead time ++     |   7|
| 44815|16 Oct 08:30| Vost        | Re: New GQ Win Brackets ++++++      |   6|
...

Nothing is calling SetSelection.

https://github.com/fiendish/aardwolfclientpackage

Top

Posted by

Fiendish USA (2,533 posts) Bio Global Moderator

Date

Reply #1 on Wed 06 Jan 2021 10:27 PM (UTC)

Message

It looks like it might be caused by https://github.com/nickgammon/mushclient/blob/0458c35cdeb807dd330c1beed9a784d4ba964b23/mushview.cpp#L3025-L3046
called from
https://github.com/nickgammon/mushclient/blob/0458c35cdeb807dd330c1beed9a784d4ba964b23/doc.cpp#L2469
when nothing is selected.

https://github.com/fiendish/aardwolfclientpackage

Top

Posted by

Fiendish USA (2,533 posts) Bio Global Moderator

Date

Reply #2 on Thu 07 Jan 2021 01:18 AM (UTC)

Message

I think https://github.com/nickgammon/mushclient/pull/61 might fix this

https://github.com/fiendish/aardwolfclientpackage

Top

Posted by

Nick Gammon Australia (23,046 posts) Bio Forum Administrator

Date

Reply #3 on Sat 09 Jan 2021 03:13 AM (UTC)

Message

That fix has been merged.

- Nick Gammon

www.gammon.com.au, www.mushclient.com

Top

The dates and times for posts above are shown in Universal Co-ordinated Time (UTC).

To show them in your local time you can join the forum, and then set the 'time correction' field in your profile to the number of hours difference between your location and UTC time.

12,400 views.

It is now over 60 days since the last post. This thread is closed. Refresh page

Go to topic: Search the forum

top