Register forum user name Search FAQ

Gammon Forum

Notice: Any messages purporting to come from this site telling you that your password has expired, or that you need to "verify" your details, making threats, or asking for money, are spam. We do not email users with any such messages. If you have lost your password you can obtain a new one by using the password reset link.
 Entire forum ➜ MUSHclient ➜ Bug reports ➜ Auto-wrap wraps incorrectly for fonts with wider bold characters
Auto-wrap wraps incorrectly for fonts with wider bold characters

It is now over 60 days since the last post. This thread is closed.     Refresh page

Posted by Fiendish   USA  (2,533 posts)  Bio   Global Moderator
Date Mon 07 Sep 2020 05:31 PM (UTC)

Amended on Mon 07 Sep 2020 05:34 PM (UTC) by Fiendish

Message
When using a font that has different normal and bold character widths, auto-wrap to window size does not account for the different bold character width when deciding where to wrap.

I use the JetBrains Mono font from https://www.jetbrains.com/lp/mono/
It comes with an ExtraBold variant that has different character widths for its regular and bold styles.

This is with the "Show Bold" font setting _not_ active https://imgur.com/i08TQsw

This is with the "Show Bold" font setting active https://imgur.com/UA4TRPY
Note here that it runs past the edge of the text rect.
https://github.com/fiendish/aardwolfclientpackage
Top
Posted by Nick Gammon   Australia  (23,070 posts)  Bio   Forum Administrator
Date Reply #1 on Wed 16 Sep 2020 05:16 AM (UTC)
Message

The auto-wrap is just a convenience-thingTM to help calculate the number of characters needed for a certain font to fit into a certain window width.

It assumes, I suppose, that the text is normally “normal” and thus the calculation is based on a non-bold font size.

If it assumed all bold then it would under-estimate for text which is usually not bold.

I don’t think this is a bug - you know that the wrapping occurs at a character count and not a pixel count. If the auto-wrap (which is something you would not frequently use) underestimates then just bump up the count a bit manually.

- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top
Posted by Fiendish   USA  (2,533 posts)  Bio   Global Moderator
Date Reply #2 on Wed 16 Sep 2020 01:29 PM (UTC)

Amended on Wed 16 Sep 2020 03:29 PM (UTC) by Fiendish

Message
Quote:
If the auto-wrap (which is something you would not frequently use) underestimates then just bump up the count a bit manually.

This isn't practical because lines nearly always have an arbitrary mixture of bold and non-bold on them at the same time. A line could be all bold or all non-bold or anything in between.

Wrapping correctly, whether using the bold setting or a non-monospace font (which apparently some players do), will require determining pixel widths based on line styles and actual text instead of a simple index. I like the simplicity of using a column width when it works, but it doesn't work for these cases.
https://github.com/fiendish/aardwolfclientpackage
Top
Posted by Nick Gammon   Australia  (23,070 posts)  Bio   Forum Administrator
Date Reply #3 on Thu 17 Sep 2020 12:28 AM (UTC)
Message
What do you mean "works"?

MUD output is generally not right-justified, so if some lines wrap a bit earlier than they might have, it's no big deal.

Just make your width enough to allow for all-bold text.
- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top
Posted by Fiendish   USA  (2,533 posts)  Bio   Global Moderator
Date Reply #4 on Thu 17 Sep 2020 04:56 AM (UTC)

Amended on Thu 17 Sep 2020 05:09 AM (UTC) by Fiendish

Message
Quote:
What do you mean "works"?

"Works" here means wrapping at the player's desired place on the screen, not just at a fixed index that wanders around the screen with the wind direction. Wrapping at an index is a reasonable proxy if a given index always corresponds to a specific horizontal position. But it doesn't make sense to wrap at an index when the index does not correspond to a specific horizontal position. The human players want the text to fill no more than a certain amount of horizontal space. They don't actually care what index is involved. They care about where on the screen the wrapping happens.

Quote:
Just make your width enough to allow for all-bold text.

The width difference is significant enough that that looks quite bad. In fact, it looks like something is broken, which is a bad impression to give. And players already don't have enough room on their screen for all of the things they want to display. Adding a bunch of dead space that makes the client look like something is broken and also takes away from the usable room for other things is not user-friendly.
https://github.com/fiendish/aardwolfclientpackage
Top
Posted by Fiendish   USA  (2,533 posts)  Bio   Global Moderator
Date Reply #5 on Thu 17 Sep 2020 05:11 AM (UTC)
Message
How's the air quality these days by the way? Did you hear? Now _we're_ on fire. It never rains, but it pours!
https://github.com/fiendish/aardwolfclientpackage
Top
Posted by Nick Gammon   Australia  (23,070 posts)  Bio   Forum Administrator
Date Reply #6 on Thu 17 Sep 2020 05:45 AM (UTC)
Message

Adding a bunch of dead space that makes the client look like something is broken and also takes away from the usable room for other things is not user-friendly.

This is the first time this has come up since the client was released in 1995. For this to look “broken” the user would have to enable display of bold (which I personally don’t do because a lot of so-called “bold” text looks weird if it is displayed in a bold font) and have a lot of discrepancies about the amount of bold text from line to line (otherwise the RH margin would not be noticeably out.

Bold text is already displayed in different colours, to make it stand out. Actually using a bold font is perhaps overkill for text. That’s why I don’t enable that option.

Anyway, it could conceivably wrap the lines at a calculated pixel width (based on the current font) however that would be somewhat slower than counting characters. Each line would have to be re-rendered (internally) character by character, as they arrived, to see if they reached the desired wrapping point.

Then you have the somewhat major issue of, what happens if someone alters their font mid-session? All the line wrapping will be out, since it was based on pixels and not character counts. So potentially all the (thousands of) lines would have to be re-wrapped, possibly breaking existing plugins which might be keeping track of things. For example, the bookmark feature bookmarks lines. What happens if the line wrapping changes?

To make this work smoothly and reliably sounds like a lot of work, for a problem that has only surfaced after the client was released 25 years ago.

OMFG! 25 years ago! That was before Facebook, YouTube, eBay, and so on. It seems a lifetime ago.

- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top
Posted by Nick Gammon   Australia  (23,070 posts)  Bio   Forum Administrator
Date Reply #7 on Thu 17 Sep 2020 05:46 AM (UTC)
Message

How’s the air quality these days by the way? Did you hear? Now we’re on fire. It never rains, but it pours!

Yes I did hear. We had major bushfires last Summer, and now you have them. But don’t worry, apparently the Earth is going to get cooler soon.

The air quality here is fine, we are just coming out of Winter, plus we have a fairly severe lockdown, so there aren’t many cars on the road.

- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top

The dates and times for posts above are shown in Universal Co-ordinated Time (UTC).

To show them in your local time you can join the forum, and then set the 'time correction' field in your profile to the number of hours difference between your location and UTC time.

17,338 views.

It is now over 60 days since the last post. This thread is closed.     Refresh page

Go to topic:           Search the forum

[Go to top] top

Information and images on this site are licensed under the Creative Commons Attribution 3.0 Australia License unless stated otherwise.

Home